-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQMStore::removeElement: do not remove non-existing MEs #11314
DQMStore::removeElement: do not remove non-existing MEs #11314
Conversation
The previous logic would not prevent calling data_.erase(data_.end()) when the requested MonitorElement does not exist, and warning is false.
backport #11050 to 74x |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X. DQMStore::removeElement: do not remove non-existing MEs It involves the following packages: DQMServices/Core @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
tracked at #11317 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…remove_non-existing_MEs_74x DQMStore::removeElement: do not remove non-existing MEs
The previous logic would not prevent calling
data_.erase(data_.end())
when the requested MonitorElement does not exist, and warning is false.