-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clang static analyzer warning using namespace in header #11324
fix clang static analyzer warning using namespace in header #11324
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X. fix clang static analyzer warning using namespace in header It involves the following packages: CalibCalorimetry/HcalTPGAlgos @cmsbuild, @mmusich, @diguida, @mulhearn, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelDataXml.cc >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelIterator.cc >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelQualityXml.cc >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalDbOmds.cc /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc: In member function 'XMLDOMBlock\* DBlmapWriter::createLMapHBEFXMLBase(std::string)': /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc:19:3: error: 'DOMDocument' was not declared in this scope DOMDocument \* loader = result -> getDocument(); ^ /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc:19:3: note: suggested alternative: In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/xerces-c/2.8.0/include/xercesc/parsers/AbstractDOMParser.hpp:25:0, from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/xerces-c/2.8.0/include/xercesc/parsers/XercesDOMParser.hpp:27, you can see the results of the tests here: |
…libCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h
@mmusich Updated dependent package CaloOnlineTool/HcalOnlineDb. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
…fix-clang-warning-2 fix clang static analyzer warning using namespace in header
No description provided.