Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Violation fixed: remove unneeded dependency on dqm #11327

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Dependency Violation fixed: remove unneeded dependency on dqm #11327

merged 1 commit into from
Sep 17, 2015

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 17, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_6_X.

Dependency Violation fixed: remove unneeded dependency on dqm

It involves the following packages:

RecoLocalMuon/GEMCSCSegment
RecoLocalMuon/GEMRecHit
RecoLocalMuon/GEMSegment

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11327 51561ef

Deletion of unneeded and incorrect dependencies on DQM. There should be no change in run-time behavior.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-17-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

smuzaffar added a commit that referenced this pull request Sep 17, 2015
Dependency Violation fixed: remove unneeded dependency on dqm
@smuzaffar smuzaffar merged commit f07b3b5 into cms-sw:CMSSW_7_6_X Sep 17, 2015
@smuzaffar smuzaffar deleted the dep-violation-reco branch September 17, 2015 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants