Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multithreading fix for 74x: AlCa modules #11352

Merged
merged 4 commits into from
Oct 10, 2015
Merged

multithreading fix for 74x: AlCa modules #11352

merged 4 commits into from
Oct 10, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

backport #10957 / #10969 to 74x

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

multithreading fix for 74x: AlCa modules

It involves the following packages:

Alignment/LaserAlignment
Calibration/HcalIsolatedTrackReco

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@mmusich
Copy link
Contributor

mmusich commented Sep 18, 2015

please test

@cmsbuild
Copy link
Contributor

+1
Tested at: 4549788
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11352/8203/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11352/8203/summary.html

@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Closed
@fwyzard
LaserAlignmentEventFilter: change into a global::EDFilter
8e5d49b 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unnecessary parameters
  - remove unnecessary caching of EventSetup products
  - remove unused methods and member variables
  - remove usage of exceptions in the FED check loop
  - change into a global::EDFilter
@fwyzard
IPTCorrector: change into a global::EDProducer
3bfca39 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - change into a global::EDProducer
@fwyzard
IsolatedPixelTrackCandidateProducer: change into a stream::EDProducer
ce19d82 
  - change most configuration parameters into const members
  - initialise them in the member initializer list
  - change into a stream::EDProducer
@fwyzard
IsolatedEcalPixelTrackCandidateProducer: change into a global::EDProd…
6131404 
…ucer

  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods
  - change into a global::EDProducer
@fwyzard fwyzard force-pushed the multithreading_74x_AlCa branch from 4549788 to 6131404 Compare September 23, 2015 19:24
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 23, 2015

rebased to merge on top of both CMSSW_7_4_X and CMSSW_7_4_12_patch4

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11352 was updated. @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6131404
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11352/8311/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11352/8311/summary.html

@davidlange6
Copy link
Contributor

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 10, 2015

@mmusich, @diguida, @franzoni, can you please sign again ?

@diguida
Copy link
Contributor

diguida commented Oct 10, 2015

+1

cmsbuild added a commit that referenced this pull request Oct 10, 2015
@cmsbuild
Merge pull request #11352 from fwyzard/multithreading_74x_AlCa
afe86be 
multithreading fix for 74x: AlCa modules
@cmsbuild cmsbuild merged commit afe86be into cms-sw:CMSSW_7_4_X Oct 10, 2015
@fwyzard fwyzard deleted the multithreading_74x_AlCa branch October 10, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @mmusich @davidlange6 @diguida