Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multithreading fix for 74x: EcalRecalibRecHitProducer #11353

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

  • change all configuration parameters into const members
  • initialise them in the member initializer list
  • remove unused methods and member variables
  • change into a global::EDProducer
  • make the consumes conditional on the data actually being used

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

EcalRecalibRecHitProducer: change into a global::EDProducer

It involves the following packages:

RecoLocalCalo/EcalRecProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11353 01efa5c

Minor code clean-up in EcalRecalibRecHitProducer. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-18-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cvuosalo
Copy link
Contributor

@fwyzard:
Could you please add to the description an explanation of the importance of adding this change to 74X and why you are making it at this late date? David may not want to merge it unless it is essential.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

This is one of a dozen PRs that backport to 74x the changes to run the HLT
with multithreading.

Ciao,
.Andrea
On 18 Sep 2015 22:03, "Carl Vuosalo" [email protected] wrote:

@fwyzard https://github.com/fwyzard:
Could you please add to the description an explanation of the importance
of adding this change to 74X and why you are making it at this late date?
David may not want to merge it unless it is essential.


Reply to this email directly or view it on GitHub
#11353 (comment).

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 21, 2015

backport of #10954 / #10966 to 74x

  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - change into a global::EDProducer
  - make the consumes conditional on the data actually being used
@fwyzard fwyzard force-pushed the multithreading_74x_EcalRecalibRecHitProducer branch from 01efa5c to 6f0b7fe Compare September 23, 2015 19:26
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11353 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

#11353 6f0b7fe

Second approval after rebasing. New Jenkins tests show no problems.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 9, 2015
…RecHitProducer

multithreading fix for 74x: EcalRecalibRecHitProducer
@cmsbuild cmsbuild merged commit ccdae08 into cms-sw:CMSSW_7_4_X Oct 9, 2015
@fwyzard fwyzard deleted the multithreading_74x_EcalRecalibRecHitProducer branch October 10, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants