-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multithreading fix for 74x: EcalRecalibRecHitProducer #11353
multithreading fix for 74x: EcalRecalibRecHitProducer #11353
Conversation
fwyzard
commented
Sep 18, 2015
- change all configuration parameters into const members
- initialise them in the member initializer list
- remove unused methods and member variables
- change into a global::EDProducer
- make the consumes conditional on the data actually being used
please test |
tracked at #11317 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X. EcalRecalibRecHitProducer: change into a global::EDProducer It involves the following packages: RecoLocalCalo/EcalRecProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@fwyzard: |
This is one of a dozen PRs that backport to 74x the changes to run the HLT Ciao,
|
- change all configuration parameters into const members - initialise them in the member initializer list - remove unused methods and member variables - change into a global::EDProducer - make the consumes conditional on the data actually being used
01efa5c
to
6f0b7fe
Compare
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…RecHitProducer multithreading fix for 74x: EcalRecalibRecHitProducer