-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended checks on geometry #11366
Extended checks on geometry #11366
Conversation
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_6_X. Extended checks on geometry It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/geant4/10.01.p02/include/Geant4/G4GDMLReadSetup.hh:47, from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/geant4/10.01.p02/include/Geant4/G4GDMLReadParamvol.hh:43, from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/geant4/10.01.p02/include/Geant4/G4GDMLReadStructure.hh:46, from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/geant4/10.01.p02/include/Geant4/G4GDMLParser.hh:43, from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-18-1100/src/SimG4Core/Geometry/src/G4CheckOverlap.cc:13: /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/geant4/10.01.p02/include/Geant4/G4GDMLRead.hh:42:47: fatal error: xercesc/parsers/XercesDOMParser.hpp: No such file or directory #include ^ compilation terminated. gmake: **\* [tmp/slc6_amd64_gcc493/src/SimG4Core/Geometry/src/SimG4CoreGeometry/G4CheckOverlap.o] Error 1 >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-18-1100/src/SimG4Core/Geometry/src/SensitiveDetectorCatalog.cc you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Pull request #11366 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Modification for Geant4 10.1p02: slightly different interface to gdml writer and introduced usage of G4EmParameters.
Fix on one static analyser warning
Extended geometry overlap checks to sub-regions, added possibility to make gdml dump of sub-detectors.
Should not have any effect on production.