Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sigmaIetaIphi for photon regression (74X not patches) #11405

Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Sep 21, 2015

Sideport of #11403.

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Fix sigmaIetaIphi for photon regression (74X not patches)

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 28, 2015

+1

for #11405 93f9992

  • bugfix to regression input variable for photon energy correction in miniAOD
  • the effect is visible only in miniAOD (analysis level; no DQM available) and it is fairly small (see plots posted in Fix sigmaIetaIphi for photon regression #11403)
  • jenkins tests pass and comparisons with baseline show no differences

This should be merged in time for re-miniAOD.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@lgray
Copy link
Contributor Author

lgray commented Sep 28, 2015

@davidlange6 This also did not make it into 7_4_13 despite being in 7_4_12_patchX...

@gpetruc

@lgray
Copy link
Contributor Author

lgray commented Sep 28, 2015

Hmm, checking something...

@lgray
Copy link
Contributor Author

lgray commented Sep 28, 2015

@davidlange6 sorry, false alarm.

@lgray
Copy link
Contributor Author

lgray commented Sep 28, 2015

@davidlange6 @slava77 indeed, this one was simply not merged before. The only missing one is the fix to the electron classifier BDT calculation...

@lgray
Copy link
Contributor Author

lgray commented Sep 29, 2015

@gpetruc @davidlange6 Ready to go here, too.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 29, 2015
…patches

Fix sigmaIetaIphi for photon regression (74X not patches)
@cmsbuild cmsbuild merged commit 1a11558 into cms-sw:CMSSW_7_4_X Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants