-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position Calc Fix 76X #11418
Position Calc Fix 76X #11418
Conversation
A new Pull Request was created by @argiro for CMSSW_7_6_X. Position Calc Fix 76X It involves the following packages: RecoParticleFlow/PFClusterProducer @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Fixing buggy code related to the ECAL 2D position that was causing sporadic crashes. There should be no change in monitored quantities. #11415 and #11417 are the 74X and 75X versions of this PR. The first has already been merged, while the second has already been approved by Reco. The code change fixes incorrect code. Jenkins tests against baseline CMSSW_7_6_X_2015-09-21-2300 show no significant differences, as expected. Additional testing was done for #11417 and found no significant changes in quantities or timing. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
removed cache for CaloGeometry