bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423

bsunanda · 2015-09-22T17:09:27Z

Remove the obsolete codes and add new codes and the corresponding cfg's

cmsbuild · 2015-09-22T17:11:12Z

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL

It involves the following packages:

Geometry/CaloTopology

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

ianna · 2015-09-24T07:01:56Z

Geometry/CaloTopology/test/testHcalTopology_cfg_dump.py

@@ -0,0 +1,237 @@
+import FWCore.ParameterSet.Config as cms


@bsunanda - did you include this file intentionally?

ianna · 2015-09-24T07:02:30Z

@cmsbuild please test

cmsbuild · 2015-09-24T07:06:19Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-24T09:16:53Z

+1
Tested at: cdabd61
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11423/8323/summary.html

cmsbuild · 2015-09-24T10:31:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11423/8323/summary.html

bsunanda · 2015-09-24T18:17:29Z

Yana - could you look into this please. They are related to unit tests for topology

From: cmsbuild [[email protected]]
Sent: 24 September 2015 12:31
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL (#11423)

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11423/8323/summary.html

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11423#issuecomment-142885702.

ianna · 2015-09-24T18:22:10Z

@bsunanda - the tests pass. What exactly in comparison do you point me to?

bsunanda · 2015-09-24T18:26:05Z

These replace the old nonworking unit tests. These are changes only to test directory -so dont know what to expect in the comparisons.

From: Ianna Osborne [[email protected]]
Sent: 24 September 2015 20:22
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL (#11423)

@bsunandahttps://github.com/bsunanda - the tests pass. What exactly in comparison do you point me to?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11423#issuecomment-143010844.

ianna · 2015-09-24T18:41:41Z

@bsunanda - ok, here is a problem reported by static checks. The compiler is complaining because it thinks nDepthBins is uninitialised:

>> Analyzing  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-22-1500/src/Geometry/CaloTopology/src/HcalTopologyRestrictionParser.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-22-1500/src/Geometry/CaloTopology/src/HcalTopology.cc:501:12: warning: The right operand of '>' is a garbage value
  if(depth > nDepthBins) {
           ^ ~~~~~~~~~~
1 warning generated.

comparison with baseline seem to be fine for everything except for DQM (20-50%) and HLT (0.0-0.1% - one test out of 1-30k). These are definitely not related to this PR.

BTW, did you see my question about configuration dump file? Did you mean to commit it?

bsunanda · 2015-09-24T18:51:22Z

I see the issue - it is set depthBinInformation. But I shall initialize that in the coming PR. I just copied the files which were there in CMSSW_6_2_X. According to me to dump file is not necessary.

From: Ianna Osborne [[email protected]]
Sent: 24 September 2015 20:41
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL (#11423)

@bsunandahttps://github.com/bsunanda - ok, here is a problem reported by static checks. The compiler is complaining because it thinks nDepthBins is uninitialised:

Analyzing /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-22-1500/src/Geometry/CaloTopology/src/HcalTopologyRestrictionParser.cc
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-22-1500/src/Geometry/CaloTopology/src/HcalTopology.cc:501:12: warning: The right operand of '>' is a garbage value
if(depth > nDepthBins) {
^ ~~~~~~~~~~
1 warning generated.

comparison with baseline seem to be fine for everything except for DQM (20-50%) and HLT (0.0-0.1% - one test out of 1-30k). These are definitely not related to this PR.

BTW, did you see my question about configuration dump file? Did you mean to commit it?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11423#issuecomment-143015601.

ianna · 2015-09-25T06:01:07Z

@bsunanda - could you, please, remove the dump file from this PR? Thanks.

bsunanda · 2015-09-25T10:46:54Z

Done that

From: Ianna Osborne [[email protected]]
Sent: 25 September 2015 08:01
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL (#11423)

@bsunandahttps://github.com/bsunanda - could you, please, remove the dump file from this PR? Thanks.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11423#issuecomment-143137340.

davidlange6 · 2015-09-26T11:54:18Z

Geometry/CaloTopology/test/HcalTopologyTester.cc

 #include "Geometry/CaloTopology/interface/HcalTopology.h"
 #include "DataFormats/HcalDetId/interface/HcalDetId.h"
 #include "DataFormats/HcalDetId/interface/HcalSubdetector.h"
+#include "CoralBase/Exception.h"


why is this dependency here? (and in the buildfile?)

Removed dependency

From: David Lange [[email protected]]
Sent: 26 September 2015 13:54
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL (#11423)

In Geometry/CaloTopology/test/HcalTopologyTester.cchttps://github.com//pull/11423#discussion_r40492941:

#include "Geometry/CaloTopology/interface/HcalTopology.h"
#include "DataFormats/HcalDetId/interface/HcalDetId.h"
#include "DataFormats/HcalDetId/interface/HcalSubdetector.h"
+#include "CoralBase/Exception.h"

why is this dependency here? (and in the buildfile?)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11423/files#r40492941.

davidlange6 · 2015-09-27T07:45:13Z

+1

cmsbuild · 2015-09-27T07:46:14Z

Pull request #11423 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

ianna · 2015-09-29T13:37:31Z

@cmsbuild please test

ianna · 2015-09-29T13:38:15Z

+1

cmsbuild · 2015-09-29T13:42:16Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-29T15:31:05Z

+1
Tested at: b11bf78
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11423/8475/summary.html

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL

cmsbuild · 2015-09-29T16:24:53Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11423/8475/summary.html

Sunanda added 2 commits September 22, 2015 19:05

Make the topology tester up-to-date with the geometry changes for HCAL

8377121

Correct typing error

cdabd61

cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 22, 2015

cmsbuild added geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Sep 22, 2015

ianna reviewed Sep 24, 2015
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Sep 24, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 24, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 24, 2015

Remove the dump cfg file

729e8bd

cmsbuild removed comparison-available tests-approved labels Sep 25, 2015

davidlange6 reviewed Sep 26, 2015
View reviewed changes

Remove dependency on CoralBase

b11bf78

cmsbuild added geometry-pending pending-signatures tests-pending orp-approved comparison-pending and removed comparison-available fully-signed geometry-approved orp-pending tests-approved labels Sep 27, 2015

cmsbuild added geometry-approved fully-signed tests-started and removed geometry-pending pending-signatures tests-pending labels Sep 29, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2015

cmsbuild added a commit that referenced this pull request Sep 29, 2015

Merge pull request #11423 from bsunanda/Run2-hcx28

4c0d462

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL

cmsbuild merged commit 4c0d462 into cms-sw:CMSSW_7_6_X Sep 29, 2015

cmsbuild mentioned this pull request Oct 19, 2015

merge SLHC updates for CaloTowers #11940

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423

bsunanda commented Sep 22, 2015

cmsbuild commented Sep 22, 2015

ianna Sep 24, 2015

ianna commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 25, 2015

bsunanda commented Sep 25, 2015

davidlange6 Sep 26, 2015

bsunanda Sep 26, 2015

davidlange6 commented Sep 27, 2015

cmsbuild commented Sep 27, 2015

ianna commented Sep 29, 2015

ianna commented Sep 29, 2015

cmsbuild commented Sep 29, 2015

cmsbuild commented Sep 29, 2015

cmsbuild commented Sep 29, 2015

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423

bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423

Conversation

bsunanda commented Sep 22, 2015

cmsbuild commented Sep 22, 2015

ianna Sep 24, 2015

Choose a reason for hiding this comment

ianna commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

cmsbuild commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 24, 2015

bsunanda commented Sep 24, 2015

ianna commented Sep 25, 2015

bsunanda commented Sep 25, 2015

davidlange6 Sep 26, 2015

Choose a reason for hiding this comment

bsunanda Sep 26, 2015

Choose a reason for hiding this comment

davidlange6 commented Sep 27, 2015

cmsbuild commented Sep 27, 2015

ianna commented Sep 29, 2015

ianna commented Sep 29, 2015

cmsbuild commented Sep 29, 2015

cmsbuild commented Sep 29, 2015

cmsbuild commented Sep 29, 2015