Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a script to check edm class transient member marked transient in root #11442

Merged
merged 1 commit into from
Sep 24, 2015
Merged

a script to check edm class transient member marked transient in root #11442

merged 1 commit into from
Sep 24, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 23, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 23, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X.

a script to check edm class transient member marked transient in root

It involves the following packages:

DataFormats/TestObjects
FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@gartung
Copy link
Member Author

gartung commented Sep 23, 2015

@Dr15Jones @smuzaffar @davidlange6

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5ee8e95
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11442/8337/summary.html

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@Dr15Jones
Copy link
Contributor

how should we proceed with the idea that this is run as part of the build process?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11442/8337/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 24, 2015
@cmsbuild
Merge pull request #11442 from gartung/FWCore-Utilities-edmCheckClass…
f3c04ae 
…Transient2

a script to check edm class transient member marked transient in root
@cmsbuild cmsbuild merged commit f3c04ae into cms-sw:CMSSW_7_6_X Sep 24, 2015
@smuzaffar
Copy link
Contributor

@Dr15Jones, I am working on it. I need to check how much overhead it will bring in to build time
I am going to update the script so that it can accept multiple rootmap files.

@gartung gartung deleted the FWCore-Utilities-edmCheckClassTransient2 branch September 25, 2015 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@gartung @cmsbuild @smuzaffar @Dr15Jones @davidlange6