Cache pointer to function created by cling

[Dr15Jones]

VTune showed that the previous way of calling into cling was causing
the ROOT internal mutex to be taken for each call. Philippe Canal
devised a way to access the cling generated function pointer directly
which avoids the locks.

This change required an update to ROOT 6.02 in order to work. That change is now in CMSSW_7_6.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Cache pointer to function created by cling

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

please test

[Dr15Jones]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1

Tested at: 6b87623
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11469/8404/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11469/8404/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[Dr15Jones]

@smuzaffar when the tests are run, is this pull request merged with the head of CMSSW_7_6_X or is it run as is? I'm trying to determine how the failure from the IB is being tickled by this pull request.

[smuzaffar]

From the PR test job I see the following

+ git cms-merge-topic -u 11469
No release tags specified, using default CMSSW_7_6_X_2015-09-27-2300.
You are on branch CMSSW_7_6_X
Checking out FWCore/Version in tag CMSSW_7_6_X_2015-09-27-2300.
Cloning into '/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-27-2300/src'...
Switched to a new branch 'from-CMSSW_7_6_X_2015-09-27-2300'
Branch from-CMSSW_7_6_X_2015-09-27-2300 set up to track remote branch CMSSW_7_6_X from official-cmssw.
HEAD is now at 2aad5e3 Merge pull request #11500 from davidlt/resolve-private-protected-part1
From .
 * [new ref]                    -> merge-attempt
From https://github.com/cms-sw/cmssw
 * [new ref]         refs/pull/11469/head -> cms-sw/refs/pull/11469/head
Switched to branch 'merge-attempt'
Merge made by the 'recursive' strategy.
 DataFormats/HLTReco/src/classes.h             |  1 +
 FWCore/Utilities/interface/FunctionWithDict.h |  3 +++
 FWCore/Utilities/src/FunctionWithDict.cc      | 21 ++++++++++++++-------
 3 files changed, 18 insertions(+), 7 deletions(-)
Switched to branch 'from-CMSSW_7_6_X_2015-09-27-2300'
Your branch is behind 'official-cmssw/CMSSW_7_6_X' by 32 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)```

so to me it looks like it is run as it is i.e. without merging it to the head of IB branch e.g. CMSSW_7_6_X

[Dr15Jones]

That would account for the unit test failure then. The place where my code 'branched' from CMSSW_7_6_X, that version of CMSSW had the version of the code that caused the unrelated test failure. Since git cms-checkdeps -a will get the version from my branch and not the release the unit test will fail. But when my changes are merged into CMSSW_7_6_X the problem will go away.

[cmsbuild]

+1
Tested at: 5b2dcc4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11469/8448/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11469/8448/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1