Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the reclustering in the MET correction and uncertainty tool #11489

Merged
merged 3 commits into from
Oct 10, 2015

Conversation

mmarionncern
Copy link

Following the discussion of https://indico.cern.ch/event/447792/?filterActive=1&showDate=all&showSession=4
this PR removes the jet clustering and enable the repro74X option in the shortcut functions used for MET reprocessing on top of miniAOD.

New features :

  • MET extractor : allows to retrieve the raw MET from an existing slimmedMET collection; the recomputation of the raw MET is thus not needed anymore if not explicitely specified in the tool
  • jet reclustering disabled per default, existing slimmedJets are directly recalibrated using the last JECs and the Type1MET is defined accordingly
  • the repro74X option has been added in the runMetCorAndUncFromMiniAOD function, allowing users to recompute the MET on top of 74X, X<12 miniAODs on the fly in a simplified way.
  • the caloMET is now copied in the new slimmedMET collection
  • automatic protection has been added against the change of process name used to create the first slimmed MET collection. Users won't have to switch manually the input tag to slimmedMET__RECO anymore

Changes expected :

  • gain of CPU performances
  • physics untouched, rounding of PFcandidate quantities removed from the computations.

Has to be done on top of #11482

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Disabling the reclustering in the MET correction and uncertainty tool

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 25, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@gpetruc
Copy link
Contributor

gpetruc commented Sep 25, 2015

Hi @mmarionncern,

This PR affects only the re-computation of type1 MET from miniAOD, not what's run in prooduction, ok?

Giovanni

@mmarionncern
Copy link
Author

@gpetruc Yes, the type1MET correction is only computed at the miniAOD level so far.

src = jetCollection,
levels = ['L1FastJet',
'L2Relative',
'L3Absolute'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naive question: shouldn't there be also L2L3Residual?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a specific case for data L1252 of the new version

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11489/8392/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

davidlange6 added a commit that referenced this pull request Oct 10, 2015
Disabling the reclustering in the MET correction and uncertainty tool
@davidlange6 davidlange6 merged commit 7ccd3ae into cms-sw:CMSSW_7_4_X Oct 10, 2015
@mmarionncern mmarionncern deleted the met/METCorTool74X-092515 branch November 14, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants