-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusts SimHits histogram binning and adds Additional Noise plots #11493
Conversation
…ng additional histograms for negative energy filters
A new Pull Request was created by @kencall for CMSSW_7_6_X. Adjusts SimHits histogram binning and adds Additional Noise plots It involves the following packages: DQMOffline/Hcal @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
I have checked DQM files generated in testing [1]. The histograms have the desired changes. Is there anything else I should do in order to get this PR accepted and merged? |
Since we haven't heard much on this thread, I just wanted to write this to get people's attention on this PR and I wanted to make sure this will be included in 7_6_X. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Adjusts SimHits histogram binning and adds Additional Noise plots
SimHits histograms filled by Validation/HcalHits/src/HcalSimHitStudy.cc and Validation/HcalHits/src/SimHitsValidationHcal.cc have some binning adjusts.
Additional noise plots have been added.