Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts SimHits histogram binning and adds Additional Noise plots #11493

Merged
merged 1 commit into from
Oct 7, 2015

Conversation

kencall
Copy link
Contributor

@kencall kencall commented Sep 25, 2015

SimHits histograms filled by Validation/HcalHits/src/HcalSimHitStudy.cc and Validation/HcalHits/src/SimHitsValidationHcal.cc have some binning adjusts.

Additional noise plots have been added.

…ng additional histograms for negative energy filters
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kencall for CMSSW_7_6_X.

Adjusts SimHits histogram binning and adds Additional Noise plots

It involves the following packages:

DQMOffline/Hcal
Validation/HcalHits
Validation/HcalRecHits

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@kencall
Copy link
Contributor Author

kencall commented Sep 30, 2015

I have checked DQM files generated in testing [1]. The histograms have the desired changes.

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11493/8424/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

Is there anything else I should do in order to get this PR accepted and merged?

@hatakeyamak
Copy link
Contributor

Since we haven't heard much on this thread, I just wanted to write this to get people's attention on this PR and I wanted to make sure this will be included in 7_6_X.

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

@vkhristenko

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 7, 2015
Adjusts SimHits histogram binning and adds Additional Noise plots
@cmsbuild cmsbuild merged commit 1d89348 into cms-sw:CMSSW_7_6_X Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants