Fixes for compatibility with pythia8 212

[mkirsano]

No description provided.

[cmsbuild]

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_7_6_X.

Fixes for compatibility with pythia8 212

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mkirsano]

Fixes for compatibility with pythia8 212 (PR cmsdist #1840). Compatible also with pythia8 210, so can be made first.

[bendavid]

Don't think we should have "using namespace" in a header file.

[bendavid]

The fix implemented here can cause a memory leak I think. The pointer to fEvAttributes should be initialized to 0 in the constructor of LHAupLesHouches, then
"fEvAttributes = new std::map<std::string, std::string >;"
could be replaced with
"if (fEvAttributes) {
fEvAttributes->clear();
} else {
fEvAttributes = new std::map<std::string, std::string >;
}
"

(then if the pointer is non-zero it should also be deleted in the destructor for LHAupLesHouches)

[mkirsano]

Thanks, Josh, I correct it. I always forget that there can be several runs.

[cmsbuild]

Pull request #11495 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

[cmsbuild]

Pull request #11495 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

[bendavid]

+1
(contingent on taking cms-sw/cmsdist#1840 of course)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[bendavid]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 51cf027
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11495/8477/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11495/8477/summary.html