Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New analysis module StripClusterMCanalysis #11499

Merged
merged 1 commit into from
Oct 7, 2015

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Sep 25, 2015

EDAnalyzer in the test directories of /Validation/TrackerRecHits. Produces a flat ntuple with si strip cluster information including that from matched MC truth. A root macro generates useful plots.
Documentation in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideStripClusterMCtruth#StripClusterMCanalysis_Ntuple_ma

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford (Bill Ford) for CMSSW_7_6_X.

New analysis module StripClusterMCanalysis

It involves the following packages:

Validation/TrackerRecHits

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

this PR adds an entuplizer which is never run in production workflows but it is included for convenience in cmssw.
@davidlange6 is this acceptable?
F.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

+1
doesn't hurt in my opinion

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 7, 2015
New analysis module StripClusterMCanalysis
@cmsbuild cmsbuild merged commit 2c7e4bc into cms-sw:CMSSW_7_6_X Oct 7, 2015
@wmtford wmtford deleted the clusNtp_764 branch January 10, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants