Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues with std::basic_stringstream usage #11505

Merged
merged 1 commit into from
Sep 26, 2015
Merged

Resolve issues with std::basic_stringstream usage #11505

merged 1 commit into from
Sep 26, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Sep 26, 2015

There is no operator<< overload taking two
std::basic_ostringstream<char>. It used to work before C++11 because
std::basic_ios provided operator void*() const. It never provided
the content of std::basic_stringstream. Instead use str()
method to get a string copy of std::basic_stringstream content.

Signed-off-by: David Abdurachmanov [email protected]

Resolve issues with std::basic_stringstream usage
0d08d74 
There is no `operator<<` overload taking two
`std::basic_ostringstream<char>`. It used to work before C++11 because
`std::basic_ios` provided `operator void*() const`. It never provided
the content of `std::basic_stringstream`. Instead use `str()`
method to get a string copy of `std::basic_stringstream` content.

Signed-off-by: David Abdurachmanov <[email protected]>
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 26, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

Resolve issues with std::basic_stringstream usage

It involves the following packages:

DQMOffline/Trigger
DataFormats/PatCandidates
Validation/EcalDigis

@danduggan, @monttj, @cmsbuild, @deguio, @vadler, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @argiro, @gpetruc, @trocino, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 0d08d74
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11505/8406/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11505/8406/summary.html

davidlange6 added a commit that referenced this pull request Sep 26, 2015
@davidlange6
Merge pull request #11505 from davidlt/std-basic_ostringstream-cleanup
1817cb3 
Resolve issues with std::basic_stringstream usage
@davidlange6 davidlange6 merged commit 1817cb3 into cms-sw:CMSSW_7_6_X Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlt @cmsbuild @davidlange6