Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hltDiff: compare TriggerResults event by event (74x) #11508

Merged
merged 12 commits into from
Oct 10, 2015
Merged

hltDiff: compare TriggerResults event by event (74x) #11508

merged 12 commits into from
Oct 10, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 26, 2015

Compare two TriggerResults collections event by event.
These can come from two collections in the same file(s), or from two different sets of files.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 26, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

hltDiff: compare TriggerResults event by event (74x)

It involves the following packages:

HLTrigger/Tools

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard fwyzard force-pushed the hltDiff branch 2 times, most recently from b2288e4 to 5ec232a Compare September 26, 2015 22:01
@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild cmsbuild added the hold label Sep 28, 2015
@cmsbuild
Copy link
Contributor

Pull request #11508 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 28, 2015

sorry, I think I'll do at least a rebase before this is ready for prime time... I'll "unhold" and requests the tests once this is ready.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9456df9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11508/8451/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11508/8451/summary.html

@fwyzard fwyzard force-pushed the hltDiff branch 2 times, most recently from 6a028bc to c947d71 Compare September 29, 2015 22:25
@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

Pull request #11508 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8739/console

davidlange6 added a commit that referenced this pull request Oct 10, 2015
@davidlange6
Merge pull request #11508 from fwyzard/hltDiff
36e53c7 
hltDiff: compare TriggerResults event by event (74x)
@davidlange6 davidlange6 merged commit 36e53c7 into cms-sw:CMSSW_7_4_X Oct 10, 2015
@cmsbuild
Copy link
Contributor

+1
Tested at: f39a106
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11508/8739/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11508/8739/summary.html

@fwyzard fwyzard deleted the hltDiff branch October 29, 2015 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-started
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @Martin-Grunewald @davidlange6