Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hltDiff: compare TriggerResults event by event (76x) #11510

Merged
merged 10 commits into from
Oct 1, 2015
Merged

hltDiff: compare TriggerResults event by event (76x) #11510

merged 10 commits into from
Oct 1, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 26, 2015

Compare two TriggerResults collections event by event.
These can come from two collections in the same file(s), or from two different sets of files.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 26, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

hltDiff: compare TriggerResults event by event (76x)

It involves the following packages:

HLTrigger/Tools

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard fwyzard force-pushed the hltDiff branch 2 times, most recently from b2288e4 to 5ec232a Compare September 26, 2015 22:01
@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11510 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9456df9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11510/8453/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11510/8453/summary.html

@fwyzard fwyzard force-pushed the hltDiff branch 2 times, most recently from 6a028bc to c947d71 Compare September 29, 2015 22:25
@fwyzard
hltDiff: compare TriggerResults event by event
dd265b2 
Compare two TriggerResults collections event by event.
These can come from two collections in the same file(s), or from two
different sets of files.
@fwyzard
hltDiff: add GNU-style long options
44d61c3
@fwyzard
hltDiff: use HLTConfigData to access the trigger information
ba107d1
@fwyzard
hltDiff: add special handling of HLTPrescaler modules
e0fc555
@fwyzard
hltDiff: save memory by allocating module types in a set, and storing…
4d5acd0 
… pointers to them in the vectors
@fwyzard
hltDiff: identify old/new collections by process name
ba4ffbf
@fwyzard
hltDiff: add a one-line summary with the number of affected events
023931d
@fwyzard
hltDiff: implement partial comparison for different HLT menus
f12c775 
In case the "old" and "new" HLT menus are different, only the common
paths are compared.
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 30, 2015

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 30, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 30, 2015

though this only adds a new stand-alone command line tool, so there is nothing to be tested...

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #11510 was updated. @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 9358824
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11510/8530/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11510/8530/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 1, 2015
@cmsbuild
Merge pull request #11510 from fwyzard/hltDiff
66508ba 
hltDiff: compare TriggerResults event by event (76x)
@cmsbuild cmsbuild merged commit 66508ba into cms-sw:CMSSW_7_6_X Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @Martin-Grunewald @davidlange6