Fix naming for fwLite VID in 74X

[lgray]

Fixes an issue with the naming of embedded objects for VID usage in FWLite.

To be clear: this PR changes the content of photons in MiniAOD during its creation. It is necessary for reMiniAOD campaign, need a release by Wednesday.

This can be patched at analysis level, but requires reconfiguration of the code and makes user recipes much more complicated.

It is included in regression/VID PRs for 76X/75X.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Fix naming for fwLite VID in 74X

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: a42ae5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8420/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56d7173
3f2d9c4
a2186ea
4b4c151
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8420/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8420/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8420/summary.html

[lgray]

@cvuosalo At the request of Slava I updated the header of this PR to be a bit more descriptive and indicate its urgency.

[lgray]

@cvuosalo Apologies for spamming: just wanting to make sure this can be signed off relatively quickly?

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[lgray]

Already tested, but OK!

[lgray]

ah, other merge commits.

[cvuosalo]

@lgray:
Extended tests are underway. I will approve this PR as soon as I can.

[cmsbuild]

+1
Tested at: a42ae5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8461/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11513/8461/summary.html

[cvuosalo]

+1

For #11513 a42ae5e

Revising naming of some embedded objects for VID usage in FWLite.

Jenkins tests against baseline CMSSW_7_4_X_2015-09-28-1100 show no significant differences. An extended test of workflow 4.53_RunPhoton2012B with 200 events against baseline CMSSW_7_4_X_2015-09-27-1100 shows no difference in product sizes for either RECO or Mini-AOD.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cvuosalo]

@lgray:
Just for clarity, could you explain what exactly changes with this PR? How would the change in event content appear?

[lgray]

@cvuosalo
If you get a miniAOD photon from the event content and do:

photon.hasUserFloat("phoChargedIsolation") it will now return true.
Previously it would not, and this causes problems downstream in some ID use scenarios.
This is because the isolation variables were named chargedHadronIso, or similar, previously.

There should be little to no change in the miniAOD size since the strings change by a few bytes at most.

[slava77]

I was expecting the branch size to change if user float names changed.
On Sep 29, 2015 3:54 AM, "Lindsey Gray" [email protected] wrote:

@cvuosalo https://github.com/cvuosalo
If you get a miniAOD photon from the event content and do:

photon.hasUserFloat("phoChargedIsolation") it will now return true.
Previously it would not, and this causes problems downstream in some ID
use scenarios.

—
Reply to this email directly or view it on GitHub
#11513 (comment).

[lgray]

@slava77 uncompressed size should change (by a few bytes), for compressed size this is in the noise.

[lgray]

@Slava7 especially in 74X since there are so many other embedded objects that start with pho.

[slava77]

I checked Carl's output files used in the test, the compressed size actually changes:

• slimmedPhotons change from 1843.09 to 1843.46 bytes/event
• slimmedElectrons change from 2190.16 to 2190.24 bytes/event
  These are the only branches the differ.
  So, it looks like there is an expected effect from user float name and value changes

[lgray]

Good.

[lgray]

@gpetruc @davidlange6 Ready to go here.

[lgray]

@slava77 Names change, values do not.

[davidlange6]

+1