Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return back modifications which can work only with Geant4 10.1 #11525

Merged
merged 1 commit into from
Sep 29, 2015
Merged

Return back modifications which can work only with Geant4 10.1 #11525

merged 1 commit into from
Sep 29, 2015

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Sep 28, 2015

Recent modification valid only for Geant4 10.1 are taken out in order to be able to return Geant4 10.0 into 7_6_X.

Recent extensions to Geant4 geometry overlap checks are added (these are not affecting production).

@civanch civanch changed the title rollbackg4 Return back modifications which can work only with Geant4 10.1 Sep 28, 2015
@civanch
Copy link
Contributor Author

civanch commented Sep 28, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 28, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_6_X.

Return back modifications which can work only with Geant4 10.1

It involves the following packages:

SimG4Core/Application
SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Sep 28, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 43408c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11525/8440/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11525/8440/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 29, 2015
@cmsbuild
Merge pull request #11525 from civanch/rollback_g4
6adae27 
Return back modifications which can work only with Geant4 10.1
@cmsbuild cmsbuild merged commit 6adae27 into cms-sw:CMSSW_7_6_X Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
3 participants
@civanch @cmsbuild @davidlange6