-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSC Halo filter: adding classes for nex filter #11528
Conversation
…s + save info in MINIAOD
A new Pull Request was created by @lathomas for CMSSW_7_6_X. CSC Halo filter: adding classes for nex filter It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
#include "FWCore/ParameterSet/interface/ParameterSet.h" | ||
#include "DataFormats/METReco/interface/BeamHaloSummary.h" | ||
|
||
class CSCTightHalo2015Filter : public edm::EDFilter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a edm::stream or edm::global (the latter fits better)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slava77 Done. I have updated the two new classes and the original one as well.
@slava77 If you are happy with the changes, can you trigger the tests? |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
CSC Halo filter: adding classes for nex filter
So far, the results of the two new working points of the filter were only stored as methods in CSCHaloData.
I have now created two EDFilters for each of them and added them to the list of metFilters.
I also added them to the lists of flags in MINIAOD.
Let me know if there's any problem !
Thanks a lot,
Laurent