Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fw core util edm check class transient #11534

Merged
merged 4 commits into from
Sep 29, 2015
Merged

Fw core util edm check class transient #11534

merged 4 commits into from
Sep 29, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 28, 2015

No description provided.

@gartung
Copy link
Member Author

gartung commented Sep 28, 2015

@smuzaffar @Dr15Jones

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X.

Fw core util edm check class transient

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #11534 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

smuzaffar
smuzaffar reviewed Sep 28, 2015
View reviewed changes
FWCore/Utilities/scripts/edmCheckClassTransients

if retval == True :
print "Error: field='"+trans+"' must be labeled transient=\"true\" in classes_def.xml for "+name+" or the equivalent class name with typedefs."
return 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why return here? don't you want to keep looping for the other transients classes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot it was in a loop. I will change it.

@smuzaffar
Copy link
Contributor

+1
looks good

smuzaffar added a commit that referenced this pull request Sep 29, 2015
@smuzaffar
Merge pull request #11534 from gartung/FWCore-Util-edmCheckClassTrans…
1f55182 
…ient

Fw core util edm check class transient
@smuzaffar smuzaffar merged commit 1f55182 into cms-sw:CMSSW_7_6_X Sep 29, 2015
@gartung gartung deleted the FWCore-Util-edmCheckClassTransient branch October 1, 2015 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
3 participants
@gartung @cmsbuild @smuzaffar