-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checksum parameter cfi export (74X) #11537
Conversation
…tion *updates to CFI files (export CRC32 checksum setting, empty LS mode setting be enabled) *inherit CRC32C checksum setting from verifyAdler32 as default value
A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X. Checksum parameter cfi export (74X) It involves the following packages: EventFilter/Utilities @mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks. |
please test |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 For Heavy Ions, exporting checksum parameter so it can be toggled as necessary. There should be no change in monitored quantities. #11535 and #11536 are the 76X and 75X versions of this PR, and they have already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-28-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Checksum parameter cfi export (74X)
CRC32 is checked by default, however parameter to control this is not exported.
We need a way to switch this off in heavy ion test setup, so two changes are provided:
Also, two other not previously exported parameters were added to cfi files, and input source parameter defaults were changed to defaults used in production.
Backport of #11535 and #11536