bsunada:Run2-hcx32 Bug fix for HcalTopology #11538
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_7_6_X. bsunada:Run2-hcx32 Bug fix for HcalTopology It involves the following packages: CondTools/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi can you please review it and eventually sign? Thanks. |
|
@bsunanda Can you please fill in the pull request description with something a little more detailed than the title? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| process = cms.Process("CaloGeometryWriter") | |||
| process.load('CondCore.DBCommon.CondDBCommon_cfi') | |||
| process.load('Configuration.StandardSequences.GeometryExtended_cff') | |||
| process.load('Configuration.Geometry.GeometryExtended_cff') | |||
| process.load('Configuration.Geometry.GeometryReco_cff') | |||
There was a problem hiding this comment.
@bsunanda - please, remove this line. All relevant producers are include through the next one with appropriate parameters. Besides, if this file is not modified, the PR will be merged faster.
Another question: does it mean Hcal geometry records in DB are wrong and need to be recreated? Thanks
There was a problem hiding this comment.
Taken your advice. But StandardSequences.GeometryExtended_cff does not have initiator for recnumbering record which is needed and when I ran without Geometry.GeometryReco_cff it did not work. Hcal geometry records for run 1 and run 2 are fine - the error was only for SLHC version which was in the 62X version and was never tested.
From: Ianna Osborne [[email protected]]
Sent: 29 September 2015 07:43
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunada:Run2-hcx32 Bug fix for HcalTopology (#11538)
In CondTools/Geometry/test/calogeometrywriter.pyhttps://github.com//pull/11538#discussion_r40636326:
@@ -2,7 +2,8 @@
process = cms.Process("CaloGeometryWriter")
process.load('CondCore.DBCommon.CondDBCommon_cfi')
-process.load('Configuration.StandardSequences.GeometryExtended_cff')
+process.load('Configuration.Geometry.GeometryExtended_cff')
+process.load('Configuration.Geometry.GeometryReco_cff')
@bsunandahttps://github.com/bsunanda - please, remove this line. All relevant producers are include through the next one with appropriate parameters. Besides, if this file is not modified, the PR will be merged faster.
Another question: does it mean Hcal geometry records in DB are wrong and need to be recreated? Thanks
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11538/files#r40636326.
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
db-pending
tests-approved
labels
|
Pull request #11538 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
geometry-approved
fully-signed
tests-started
and removed
geometry-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
bsunada:Run2-hcx32 Bug fix for HcalTopology
The bug from detId to hasedId had a bug for HB which is corrected. Also the script for Calowriter needs an additional cff.