Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit namespace for std. #11540

Merged
merged 1 commit into from Sep 29, 2015
Merged

Add explicit namespace for std. #11540

merged 1 commit into from Sep 29, 2015

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2015

Needed to compile vs Pythia8.212 since "using namespace std" is no longer in one of the Pythia8 headers.

Needed to compile vs Pythia8.212.
@ghost
Copy link
Author

ghost commented Sep 29, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 29, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_6_X.

Add explicit namespace for std.

It involves the following packages:

FastSimulation/ParticleDecay
GeneratorInterface/Pythia8Interface

@vciulli, @civanch, @covarell, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @thuer, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

+1

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 29, 2015
Add explicit namespace for std.
@cmsbuild cmsbuild merged commit a5f7942 into cms-sw:CMSSW_7_6_X Sep 29, 2015
@ghost ghost deleted the fix_std_76X branch September 30, 2015 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants