Central bunch spacing producer #11544
Conversation
|
@davidlange6 is it already needed in PAT (for regressions on the fly) |
|
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X. Central bunch spacing producer It involves the following packages: Configuration/StandardSequences @cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. |
|
@davidlange6 Ah, see what you mean. There are no hardcoded instances of it. I'll send you a PR with the appropriate python updates. |
|
please test
|
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 29-Sep-2015 13:43:56 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'MINIAODSIMoutput_step'
[2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'
[3] Calling produce method for unscheduled module PATElectronSlimmer/'slimmedElectrons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: unsigned int
Looking for module label: bunchSpacingProducer
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 29-Sep-2015 13:45:55 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 182124 lumi: 40 event: 1893722
[1] Running path 'reconstruction_step'
[2] Calling event method for module CorrectedECALPFClusterProducer/'particleFlowClusterECAL'
[3] Calling produce method for unscheduled module PFClusterProducer/'particleFlowClusterECALUncorrected'
[4] Calling produce method for unscheduled module PFRecHitProducer/'particleFlowRecHitECAL'
[5] Calling produce method for unscheduled module EcalRecHitProducer/'ecalRecHit'
[6] Calling produce method for unscheduled module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: unsigned int
Looking for module label: bunchSpacingProducer
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 29-Sep-2015 13:48:35 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'local_digireco'
[2] Calling event method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: unsigned int
Looking for module label: bunchSpacingProducer
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
you can see the results of the tests here: |
|
ah - right, all of the other reco sequences… will update.
|
|
@cmsbuild, please test |
| @@ -3,5 +3,6 @@ | |||
| from PhysicsTools.PatAlgos.producersLayer1.patCandidates_cff import * | |||
| from PhysicsTools.PatAlgos.selectionLayer1.selectedPatCandidates_cff import * | |||
| from PhysicsTools.PatAlgos.slimming.slimming_cff import * | |||
| from RecoLuminosity.LumiProducer.bunchSpacingProducer_cfi import * | |||
There was a problem hiding this comment.
Yep, that'll do just fine too. Thanks.
|
The tests are being triggered in jenkins. |
|
-1 Tested at: f3e377a /bin/sh: -c: line 0: you can see the results of the tests here: |
|
@Degano @smuzaffar could you please check the error message reporting: either the style has changed |
|
pleas test looks like my last changes to set timeout for unit tests did not go well |
|
please test looks like my last changes to set timeout for unit tests did not go well |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
tests-started
and removed
comparison-available
tests-rejected
tests-pending
labels
|
identity in all of the tests. Good. |
Central bunch spacing producer
| bunchSpacing = *bunchSpacingH; | ||
| } | ||
|
|
||
| std::cout << "Derived from run number " << bunchSpacing << std::endl; |
There was a problem hiding this comment.
debug printout… whoops
On Oct 1, 2015, at 2:11 PM, Slava Krutelyov [email protected] wrote:
In RecoLuminosity/LumiProducer/plugins/BunchSpacingProducer.cc:
- run == 209089 ||
- run == 209106 ||
- run == 209109 ||
- run == 209146 ||
- run == 209148 ||
- run == 209151) {
bunchSpacing = 25;- }
- }
- else{
- edm::Handle bunchSpacingH;
- e.getByToken(bunchSpacing_,bunchSpacingH);
- bunchSpacing = *bunchSpacingH;
- }
- std::cout << "Derived from run number " << bunchSpacing << std::endl;
cout, really?
—
Reply to this email directly or view it on GitHub.
attempt two at making a PR for a new module to centralize the bunch spacing in reco/analysis. This time I've included a parameter to allow prompt to override the bunch spacing in configuration based on the processing scenario being used.
Instead of storing this output, I suggest that this module just be run as needed. I've added it to the reco sequence, which should be sufficient for all current consumers. Eventually we'll need it in PAT as well.