Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a formula evaluator to replace TFormula calls #11554

Merged
merged 1 commit into from
Oct 10, 2015

Conversation

Dr15Jones
Copy link
Contributor

Created a reco::FormulaEvaluator class which can parse a subset of
the TFormula expressions. The parsing and function evaluation are
done using stateless classes so are thread safe and extremely thread
efficient. The formula parser is shared by all reco::FormulaEvaluators
to save memory and since the parser is stateless it can efficiently
be called by multiple threads simultaneously.

This is a back port from CMSSW_7_6 of #11516

Created a reco::FormulaEvaluator class which can parse a subset of
the TFormula expressions. The parsing and function evaluation are
done using stateless classes so are thread safe and extremely thread
efficient. The formula parser is shared by all reco::FormulaEvaluators
to save memory and since the parser is stateless it can efficiently
be called by multiple threads simultaneously.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Added a formula evaluator to replace TFormula calls

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 1, 2015

+1

for #11554 179d4e9

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Oct 10, 2015
Added a formula evaluator to replace TFormula calls
@davidlange6 davidlange6 merged commit 3a6a96d into cms-sw:CMSSW_7_4_X Oct 10, 2015
@Dr15Jones
Copy link
Contributor Author

This needs the bug fix applied to CMSSW_7_6. I'll try to back port at the airport.

@Dr15Jones
Copy link
Contributor Author

There isn't a problem with this merge since the code isn't used in 7_4 yet.

@Dr15Jones Dr15Jones deleted the formulaEvaluator_7_4 branch December 8, 2015 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants