Update tracking MC validation scripts #11571

makortel · 2015-09-30T14:06:47Z

This PR contains a major update to the tracking MC validation scripts:

Much more automation and flexibility
- Now the scripts produce what exist in the DQM files following the defined set of plots and their instructions instead of the latter being a strict requirement
Generate the HTML pages (if requested)
- Earlier these were managed manually
Updates to the plots following the MultiTrackValidator development since 750pre4 (Update tracking MC validation scripts #9882)

Based on top of 7_6_0_pre2, should have no effect on standard workflows.

Use case: histogram name changes

This commit starts a series of development to make the plot production more automatic, and the best modus operandi would be to plot what we have in the DQM files, so this option will be the new default.

It is much more practical way than the constructor.

Removing it makes further development a bit easier

Plotter will become a single entry point for clients

- Reorder samples - Enable premixing vs. classical mixing also for FastSim - Run vertex validation inside trackingPerformanceValidation.py (to auto-generate all HTML pages)

…actice this way)

cmsbuild · 2015-09-30T14:11:18Z

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Update tracking MC validation scripts

It involves the following packages:

Validation/RecoTrack
Validation/RecoVertex

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

deguio · 2015-09-30T14:46:15Z

please test

deguio · 2015-09-30T14:46:17Z

+1

cmsbuild · 2015-09-30T14:46:20Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-30T14:46:21Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-30T14:51:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-30T21:39:23Z

+1
Tested at: 79593ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11571/8517/summary.html

cmsbuild · 2015-09-30T21:41:33Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-30T22:51:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11571/8517/summary.html

cmsbuild · 2015-09-30T22:56:27Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-10-01T10:30:41Z

+1

Update tracking MC validation scripts

makortel added 30 commits September 28, 2015 10:02

Add more campaigns

26845b5

Tune plots

44507e2

Produce summary plots

440d611

Plot tracks from jets and btv selection

d119013

Allow non-existence of a subdir from trackAlgoMap

187b4df

Update again FastSim pileup sample naming

da5be75

Allow overriding the V0001 part of the DQM file name

9af1f24

Streamline premixing vs classical mixing comparison

986eed0

Allow specifying different histograms for different files

e7f6063

Use case: histogram name changes

Filter out Nones when computing the number of histograms in a plot

440afbf

Calculate errors properly when normalizing to unit area

c32050b

Make missingOk/ignoreIfMissing/ignoreMissing mode the default

fab5973

This commit starts a series of development to make the plot production more automatic, and the best modus operandi would be to plot what we have in the DQM files, so this option will be the new default.

Deliver saveFormat only via Plotter.draw()

a9e2793

It is much more practical way than the constructor.

Separate PlotFolder functionality from Plotter

7348859

Remove AlgoOpt as obsolete feature

9dbf96d

Removing it makes further development a bit easier

First step towards more automated plot production

639f6dd

Plotter will become a single entry point for clients

Do not draw empty PlotGroups (TCanvases)

202786c

Add support for making plots from the new MTV instances

dd80ea6

Add possibility to limit PlotFolders only to pileup samples

21cbaae

Add generalTracks back to the summary plot

b4d2b00

Add automatic generation of the HTML report pages

44a613d

MTV flavours back in business

5c77e0e

Enable again summary plots, some further tuning

96900aa

Add possibility to not do fast vs. fullsim comparison

db5d7c0

Avoid bunch of ifs with a "dummy" HtmlReportDummy object

5d87fea

Better treatment for obtaining the list of subdirs under dir

492e47c

Update plotting scripts

d2cf309

- Reorder samples - Enable premixing vs. classical mixing also for FastSim - Run vertex validation inside trackingPerformanceValidation.py (to auto-generate all HTML pages)

Move parameters from doPlots() to constructor (makes more sense in pr…

0b0b70a

…actice this way)

Support HTML generation from trackingCompare.py

73e8719

Add --html option to makeTrackValidationPlots.py

9516198

cmsbuild added pending-signatures tests-pending orp-pending comparison-pending labels Sep 30, 2015

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 30, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 30, 2015

cmsbuild added orp-approved and removed orp-pending labels Oct 1, 2015

cmsbuild added a commit that referenced this pull request Oct 1, 2015

Merge pull request #11571 from makortel/trackingValidation_v4

ebde143

Update tracking MC validation scripts

cmsbuild merged commit ebde143 into cms-sw:CMSSW_7_6_X Oct 1, 2015

makortel deleted the trackingValidation_v4 branch October 20, 2016 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tracking MC validation scripts #11571

Update tracking MC validation scripts #11571

makortel commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

deguio commented Sep 30, 2015

deguio commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

davidlange6 commented Oct 1, 2015

Update tracking MC validation scripts #11571

Update tracking MC validation scripts #11571

Conversation

makortel commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

deguio commented Sep 30, 2015

deguio commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

davidlange6 commented Oct 1, 2015