-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch on hadronFlavourHasPriority for b-tag Validation module. #11572
Conversation
A new Pull Request was created by @acaudron for CMSSW_7_6_X. Switch on hadronFlavourHasPriority for b-tag Validation module. It involves the following packages: DQMOffline/RecoB @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
The jenkins tests job failed, please try again. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 76abc55 cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 13:43:54 2015-date Wed Oct 7 13:34:39 2015 s - exit: 16640 you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Switch on hadronFlavourHasPriority for b-tag Validation module.
Following the changes observed by the validation of 760pre5 and their understanding:
https://hypernews.cern.ch/HyperNews/CMS/get/relval/4093/44/1.html
the issue comes from the fact that hadronFlavourHasPriority was set to by default to False but the b-ta DQM stay unchanged implying an undesired changed from hadron based flavour to parton based flavour for b and c-jets.
In summary, this PR allow to get back to the definition of 760pre4.
In a close future we have to make sure to synchronize better the light flavour definition with the one which will be used to extract the b-tag SFs, by the analyses and according to the miniAOD definition (based on prunedGenParticles): it means probably merging udsg+non-identified jets in one single category.
If this PR is ok for everyone, we have to backport it to 75x and 74x.
Adding @swertz @pablodecm as they may want to follow the discussion if any.