Convert NjettinessAdder to edm::stream

[lgray]

Move NjettinessAdder to edm::stream since the underlying external is fixed by cms-sw/cmsdist#1745.

Purely technical.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Convert NjettinessAdder to edm::stream

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8505/console

[lgray]

@cmsbuild please test

[slava77]

Is the fastjet contrib piece used in this code thread safe?
I recall there was a Q&A with Chris about it, but I can't recall now if
it needed a fix in the external
or was good as is.

On 9/30/15 10:51 AM, cmsbuild wrote:

A new Pull Request was created by @lgray https://github.com/lgray
(Lindsey Gray) for CMSSW_7_6_X.

Convert NjettinessAdder to edm::stream

It involves the following packages:

RecoJets/JetProducers

@cmsbuild https://github.com/cmsbuild, @cvuosalo
https://github.com/cvuosalo, @slava77 https://github.com/slava77 can
you please review it and eventually sign? Thanks.
@rappoccio https://github.com/rappoccio, @jdolen
https://github.com/jdolen, @ahinzmann https://github.com/ahinzmann,
@TaiSakuma https://github.com/TaiSakuma, @yslai
https://github.com/yslai, @nhanvtran https://github.com/nhanvtran,
@schoef https://github.com/schoef, @mariadalfonso
https://github.com/mariadalfonso this is something you requested to
watch as well.
You can sign-off by replying to this message having '+1' in the first
line of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
If you are a L2 or a release manager you can ask for tests by saying
'please test' in the first line of a comment.
@Degano https://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

—
Reply to this email directly or view it on GitHub
#11577 (comment).

[lgray]

The follow up is in the link in the PR description. It's in the IBs since some time.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1

Tested at: 793cdb8
I found errors in the following unit tests:

/bin/sh: -c: line 0: `if [ "X" == "Xyes" ] ; then /bin/echo "Package "RecoJets/JetProducers": Skipping test test-large-voronoi-area"; else /bin/echo "Package "RecoJets/JetProducers": Running test test-large-voronoi-area" && [ -d tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area ] || /bin/mkdir -p tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area && /bin/rm -f tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log; /bin/touch tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && /bin/echo " " >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && /bin/echo "===== Test "test-large-voronoi-area" ====" >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && export PATH=/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-29-2300/test/slc6_amd64_gcc493:/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-29-2300/src/RecoJets/JetProducers/test:/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-29-2300/bin/slc6_amd64_gcc493:/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-29-2300/external/slc6_amd64_gcc493/bin:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_7_6_X_2015-09-29-2300/bin/slc6_amd64_gcc493:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_7_6_X_2015-09-29-2300/external/slc6_amd64_gcc493/bin:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/llvm/3.6-kpegke2/bin:/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/gcc/4.9.3/bin:/tmp/cmsbuild/workspace/ib-any-integration/cms-git-tools:/afs/cern.ch/cms/caf/scripts:/afs/cern.ch/cms/common:/afs/cern.ch/cms/bin:/afs/cern.ch/group/zh/bin:/afs/cern.ch/user/c/cmsbuild/scripts:/afs/cern.ch/cms/caf/scripts:/cvmfs/cms.cern.ch/common:/cvmfs/cms.cern.ch/bin:/usr/sue/bin:/usr/lib64/qt-3.3/bin:/usr/kerberos/sbin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin && timeout 3600 ((test-large-voronoi-area ) >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log 2>&1 || (/bin/echo "" && /bin/echo "---> test test-large-voronoi-area had ERRORS") >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log) && /bin/echo " " >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && /bin/echo "^^^^ End Test test-large-voronoi-area ^^^^" >> tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && /bin/cat tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log && /bin/cat tmp/slc6_amd64_gcc493/src/RecoJets/JetProducers/test/test-large-voronoi-area/testing.log >> /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-29-2300/logs/slc6_amd64_gcc493/testing.log; fi'

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11577/8511/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11577/8511/summary.html

[cmsbuild]

+1
Tested at: 793cdb8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11577/8525/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11577/8525/summary.html

[cvuosalo]

+1

For #11577 793cdb8

Converting Njettiness to edm:stream to enhance multi-threading. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-30-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1