bsunanda:Run2-hcx34 Avoid the crashes in the DQM code

[bsunanda]

It is not a long term fix. The DQM codes for HCAL needs revision

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx34 Avoid the crashes in the DQM code

It involves the following packages:

DQM/HcalMonitorTasks

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1

Tested at: f403a0d
I found errors in the following unit tests:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8532/summary.html

[davidlange6]

@bsunanda - seems there are still problems
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8532/runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

[bsunanda]

Made changes - hope this cures

---

From: David Lange [[email protected]]
Sent: 01 October 2015 12:26
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx34 Avoid the crashes in the DQM code (#11579)

@bsunandahttps://github.com/bsunanda - seems there are still problems
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8532/runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11579#issuecomment-144688530.

[cmsbuild]

Pull request #11579 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: b5e2eed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8575/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8575/summary.html

[smuzaffar]

ping @deguio ?

[bsunanda]

Added the changes and tested against 9.0 where it works and there is no copy of HcalTopology

---

From: Federico De Guio [[email protected]]
Sent: 05 October 2015 17:10
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx34 Avoid the crashes in the DQM code (#11579)

ok.. reading now chris' comment

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11579#issuecomment-145563817.

[cmsbuild]

Pull request #11579 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

[bsunanda]

@deguio Could you please look at it urgently. This is supposed to remove crashes in Hcal DQM

---

From: cmsbuild [[email protected]]
Sent: 05 October 2015 19:26
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx34 Avoid the crashes in the DQM code (#11579)

Pull request #11579#11579 was updated. @cmsbuildhttps://github.com/cmsbuild, @dandugganhttps://github.com/danduggan, @vanbesienhttps://github.com/vanbesien, @deguiohttps://github.com/deguio can you please check and sign again.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11579#issuecomment-145605216.

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 232ee8b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8641/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11579/8641/summary.html

[deguio]

+1
@vkhristenko

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[vkhristenko]

I didn't even know about the existence of this....