-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Run 2 eras to configure FastSim properly #11583
Conversation
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X. Update Run 2 eras to configure FastSim properly It involves the following packages: FastSimulation/Configuration @cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 thanks @mark-grimes |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Update Run 2 eras to configure FastSim properly
Currently the Run 2 eras do not configure FastSim the same as the postLS1Customs. This brings them both into line. I've done this in a functional way so that it works for both "gctDigis" -> "simGctDigis" (Run 1); and "caloStage1LegacyFormatDigis" -> "simCaloStage1LegacyFormatDigis" (Run 2). If preferred I could keep the Run 1 lines the same and add
etcetera.
Note there is still a difference between the era and the customisation
In the customisation,
process.misalignedCSCGeometry.useGangedStripsInME1a
is True whereas in the era it's False. I'm pretty sure the value for the era is correct, and the customisation wrong. Could someone from FastSim confirm?I've done a comparison of how the config for era differs to customisations in workflows 5.1, 5.2, 135.1 and 135.4 here:
http://grimes.web.cern.ch/grimes/eraProcessDiffs/processDiffs_FastSim-7_6_X_2015-09-30-1100-PR11466-mark-grimes_fixRun2EraInFastSim.html
The 5.x tests show nothing there because they're exactly the same. Don't worry
outputCommands
"unexpected" difference, the commands are just in a different order but functionally the same.