-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add member function in FillInfo to check the injection scheme for 25 ns. #11588
Conversation
A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X. Add member function in FillInfo to check the injection scheme for 25 ns. It involves the following packages: CondFormats/RunInfo @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
please test |
@slava77 @davidlange6 this is the minimal step to allow people to check the bunch spacing. |
The tests are being triggered in jenkins. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
please test |
+1 |
The tests are being triggered in jenkins. |
@ggovi ping :-) |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add member function in FillInfo to check the injection scheme for 25 ns.
This adds a dummy test for the bunch spacing information: it returns true if the injection scheme string starts with
25ns
.The correct check to be done is to test the
bitset
and look for "holes".