DataFormats/TrackReco: remove intrusive macros breaking stdlibc++ #11590
Conversation
The test itself is moved to `test::TestHitPattern::test()` for a better isolation and friendship is added with `reco::HitPattern`. This also revealed that `struct PatternSet` must be a friend with `reco::HitPattern`. `PatternSet` ctor calls public `PatternSet::fill` method, which calls `HitPattern::call` which is private. The code was relaying on `#define private public` to get these class working together. Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. DataFormats/TrackReco: remove intrusive macros breaking stdlibc++ It involves the following packages: DataFormats/TrackReco @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
|
The jenkins tests job failed, please try again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
ping^1 |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
DataFormats/TrackReco: remove intrusive macros breaking stdlibc++
The test itself is moved to
test::TestHitPattern::test()for a betterisolation and friendship is added with
reco::HitPattern.This also revealed that
struct PatternSetmust be a friend withreco::HitPattern.PatternSetctor calls publicPatternSet::fillmethod, which calls
HitPattern::callwhich is private. The code wasrelaying on
#define private publicto get these class workingtogether.
Compiles fine and test is working.
Signed-off-by: David Abdurachmanov [email protected]