CalibTracker/SiStripDCS: remove intrusive macros breaking libstdc++ #11592
Conversation
We cannot redefine 'private' and 'protected' keywords via macros to e.g. 'public'. This is extremely intrusive and breaks encapsulation. This does not work anymore with new libstdc++ libraries, because foward delcaration of struct is implicitly private and then implementation is under explicit private clause. Redefining 'private' only change one of them thus creating compile-time errors in sstream. Details in PR65899 (GCC BZ). It's WONTFIX. Such cleanups are required for GCC 5 and above. Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. CalibTracker/SiStripDCS: remove intrusive macros breaking libstdc++ It involves the following packages: CalibTracker/SiStripDCS @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
ping^1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
…def-clean CalibTracker/SiStripDCS: remove intrusive macros breaking libstdc++
We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.
This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.
Details in PR65899 (GCC BZ). It's WONTFIX.
Such cleanups are required for GCC 5 and above.
Signed-off-by: David Abdurachmanov [email protected]