-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface) #11595
Conversation
The 'evtgenlhc' external is considered old according to Roberto Covarelli and we should remove it. Signed-off-by: David Abdurachmanov <[email protected]>
A new Pull Request was created by @davidlt for CMSSW_7_6_X. [RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface) It involves the following packages: GeneratorInterface/EvtGenInterface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks. |
Note, it's plugin removal. The only way to test this is to add this to IB. |
The tests are being triggered in jenkins. |
@smuzaffar wasn't it always getting plugin from AFS even if you delete it? |
No, for each checked out package (in dev area) scram creates poisoned plugin cache. so if a plugin is removed then plugin manager should complain if someone tries to load it |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Apparently 521.0 workflow is now working (something changed in a month), but still tested on machine with access to CVMFS, all fine: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
[RFC] Removal of 'evtgenlhc' external (EvtGenLHC91, EvtGenLHCInterface)
@davidlt done in cms-sw/cmsdist#1871 |
The 'evtgenlhc' external is considered old according to Roberto
Covarelli and we should remove it.
Signed-off-by: David Abdurachmanov [email protected]