For HI HLT: migration of 5 HI tracking modules to stream modules

[kkrajczar]

Dear all,

5 HI Tracking modules used by HI HLT have been migrated to stream modules in this PR. The purpose was to make the modules multithread-compliant. A 75X backport will follow in minutes. I have tested the HI HLT results with and without this PR and achieved the same rates in the two cases.

Cheers,
Krisztian

@fwyzard, @mandrenguyen, @istaslis, @dgulhan, @perrotta, @Martin-Grunewald

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_6_X.

For HI HLT: migration of 5 HI tracking modules to stream modules

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
Tested at: 50696fb
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11603/8554/summary.html

[kkrajczar]

The RelVals error is a timeout error. Also, the RelVals for the 75X backport PR (i#11604) has completed successfully.

[slava77]

@cmsbuild please test
maybe it works this time

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 50696fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11603/8566/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11603/8566/summary.html

[slava77]

+1

for #11603 50696fb

• code changes are in line with the PR description. The modules are in fact also running in regular HI RECO and make up for just under 1% of CPU there.
• jenkins tests pass and comparisons with baseline show no difference

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1