Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use private 'XrdCl::FileSystem::FileSystem(const XrdCl::FileSystem&) #11606

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 1, 2015

The following showed up after a switch to xrootd 4.2.3 happened in
CMSSW_7_6_DEVEL_X IBs. The ctor 'XrdCl::FileSystem::FileSystem(const
XrdCl::FileSystem&)' is private and should not be used.

Signed-off-by: David Abdurachmanov [email protected]

…stem&)'

The following showed up after a switch to xrootd 4.2.3 happened in
CMSSW_7_6_DEVEL_X IBs. The ctor 'XrdCl::FileSystem::FileSystem(const
XrdCl::FileSystem&)' is private and should not be used.

Signed-off-by: David Abdurachmanov <[email protected]>
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

Do not use private 'XrdCl::FileSystem::FileSystem(const XrdCl::FileSystem&)

It involves the following packages:

Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

@bbockelm

@bbockelm
Copy link
Contributor

bbockelm commented Oct 1, 2015

Oh duh, good catch.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@davidlt
Copy link
Contributor Author

davidlt commented Oct 2, 2015

Could we get this in to revive DEVEL_X IBs?

@smuzaffar
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 2, 2015
Do not use private 'XrdCl::FileSystem::FileSystem(const XrdCl::FileSystem&)
@davidlange6 davidlange6 merged commit c5086a2 into cms-sw:CMSSW_7_6_X Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants