New GTs for 76X: L1,HLT,Geometry and HCAL changes #11609

mmusich · 2015-10-01T17:30:45Z

Summary of changes

Run I Simulation:

Ideal: 76X_mcRun1_design_v4 as 76X_mcRun1_design_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
Realistic: 76X_mcRun1_realistic_v4 as 76X_mcRun1_realistic_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
Heavy Ion: 76X_mcRun1_HeavyIon_v4 as 76X_mcRun1_HeavyIon_v2 with the following changes:
- Adding BDT taggers as GBRForest payloads with new labels for GBRWrapperRcd
- Adding new label for HeavyIonRcd handling HF Towers HydjetDrum method;
- Updating HCAL response corrections to take into account the change of scale in Method3
proton-Lead: 76X_mcRun1_pA_v4 as 76X_mcRun1_pA_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd

Run II Simulation:

Ideal: 76X_mcRun2_design_v4 as 76X_mcRun2_design_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
- adding new offline JEC from 2015 data analysis
- adding new HLT JEC from 2015 data anaylsis
- moving to V5 version of L1Trigger Menu for Stage1
- fixing L1 RCT parameters
- updating Zero Suppression threshold for HCAL: HF is non-ZS
- adding L1TCaloParams payload
Asymptotic: 76X_mcRun2_asymptotic_v4 as 76X_mcRun2_asymptotic_v2 with the following changes:
- Adding Calorimeter Parameters for L1T
- Adding BDT taggers as GBRForest payloads with new labels for GBRWrapperRcd
- Updating L1T menu to be in synch with online data taking
- Updating L1T RCT parameters to be in synch with online data taking
- Updating Pixel bad channel map as at the beginning of Run2015D era
- Updating Zero Suppression threshold for HCAL: HF is non-ZS
- Updating HCAL response corrections to take into account the change of scale in Method3
- Updating JEC for HLT and RECO (also supporting Puppi).
Startup 76X_mcRun2_startup_v4 as 76X_mcRun2_startup_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
- adding new offline JEC from 2015 data analysis
- moving to V5 version of L1Trigger Menu for Stage1
- fixing L1 RCT parameters
- updating Zero Suppression threshold for HCAL: HF is non-ZS
- adding L1TCaloParams payload
- updating SiPixelQuality dead channel map to v28
Heavy Ion 76X_mcRun2_HeavyIon_v4 as 76X_mcRun2_HeavyIon_v2 with the following changes:
- updated HCAL response corrections from Data/MC studies
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
- adding new offline JEC from 2015 data analysis
- adding new HLT JEC from 2015 data anaylsis
- moving to V5 version of L1Trigger Menu for Stage1
- fixing L1 RCT parameters
- updating Zero Suppression threshold for HCAL: HF is non-ZS
- adding L1TCaloParams payload
- updating SiPixelQuality dead channel map to v28
- adding new label for HeavyIonRcd handling HF Towers HydjetDrum5 method;

Run2 data

Offline Processing 76X_dataRun2_v3 as 76X_dataRun2_v2 with the following changes:
- taxonomy changes for DT and CSC Alignment parameter errors
- updated HCAL response corrections from Data/MC studies
- fixing ECAL pulse shapes for ECAL multifit
- updated HCAL channel quality
- adding BTV tagger as GBRForest payloads for GBRWrapperRcd
- adding new offline JEC from 2015 data analysis
- adding new HLT JEC from 2015 data analysis
- taxonomy change for the SiStrip O2O tags
- updating HF Towers label for HeavyIonRcd
HLT Processing 76X_dataRun2_HLT_frozen_v3 as 76X_dataRun2_HLT_frozen_v2 (snapshot time 2015-10-01 16:41:00 UTC) with the following changes:
- Taxonomy change for CSC and DT APE
- Taxonomy change for SiStrip Backplane corrections in deconvolution mode

Run1 Data

Offline Processing 76X_dataRun1_v3 as 76X_dataRun1_v2 with the following changes:
- Taxonomy change for CSC and DT APE
- Adding BDT taggers as GBRForest payloads with new labels for GBRWrapperRcd
- Updating SiStrip O2O tags (bad channels, FED cabling, latency, pedestals, threshold) with the prompt version. BEWARE: the noise tag is not updated yet, so it does not cover Run2.
- Updating ECAL pulse shapes for Multi fit method in local reco: first IOV covering Run1 as in MC, second IOV covering Run2 as per Run2015B analysis
- Updating HCAL bad channel map as per Run2015B-C analysis
- Updating HCAL response corrections to take into account the change of scale in Method3 starting from Run2015B
- Updating HF Towers centrality for Heavy Ion
HLT Processing 76X_dataRun1_HLT_frozen_v3 as 76X_dataRun1_HLT_frozen_v2 (snapshot time 2015-10-01 16:41:00 UTC) with the following changes:
- Taxonomy change for CSC and DT APE
- Taxonomy change for SiStrip Backplane corrections in deconvolution mode

Upgrades

Upgrade (phase-I) 76X_upgrade2017_design_v0 as 75X_upgrade2017_design_v4 with the following changes:
- Added L1T Calorimeter Parameters
- Added HCAL parameters in new version of the condition object
- Updated HCAL RECO geometry as for Run2
- Updated SIM geometry in the Ideal scenario (as a placeholder for Run2)
- Removed unused SIM geometries.

cmsbuild · 2015-10-01T17:31:11Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_6_X.

New GTs for 76X: L1,HLT,Geometry and HCAL changes

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

mmusich · 2015-10-01T17:31:41Z

please test

mmusich · 2015-10-01T17:33:45Z

@Martin-Grunewald I suppose this will not pass the tests because due to the inconsistent L1 and HLT menus....

cmsbuild · 2015-10-01T17:36:08Z

The tests are being triggered in jenkins.

…menu in GT

mmusich · 2015-10-01T17:38:14Z

please aknowlegde changes

diguida · 2015-10-01T17:38:45Z

@Martin-Grunewald we cherry-picked Configuration/HLT/python/autoHLT.py change as in #11391

cmsbuild · 2015-10-01T17:41:10Z

Pull request #11609 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich can you please check and sign again.

diguida · 2015-10-01T17:41:36Z

please test

cmsbuild · 2015-10-01T17:46:08Z

The tests are being triggered in jenkins.

cmsbuild · 2015-10-01T19:56:29Z

+1
Tested at: 1904d66
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8561/summary.html

cmsbuild · 2015-10-01T20:16:42Z

+1
Tested at: 1904d66
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8560/summary.html

cmsbuild · 2015-10-01T20:49:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8561/summary.html

cmsbuild · 2015-10-01T21:32:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8560/summary.html

cmsbuild · 2015-10-06T18:11:37Z

The tests are being triggered in jenkins.

cmsbuild · 2015-10-06T18:11:39Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

New GTs for 76X: L1,HLT,Geometry and HCAL changes

cmsbuild · 2015-10-06T20:26:04Z

-1

Tested at: 1904d66
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 6 21:59:51 2015-date Tue Oct 6 21:55:30 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 6 22:08:55 2015-date Tue Oct 6 22:06:03 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Oct 6 22:15:53 2015-date Tue Oct 6 22:11:22 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8650/summary.html

Martin-Grunewald · 2015-10-06T20:30:02Z

#11584

diguida · 2015-10-06T20:31:05Z

@Martin-Grunewald see my comments therein: we should make sure TMath is either not used or is supported.

cmsbuild · 2015-10-06T21:24:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11609/8650/summary.html

Martin-Grunewald · 2015-10-08T06:30:55Z

@diguida @mmusich @slava77
Does the new v5 L1T menu not enter the run2_hlt GT? @slava77 complains about failing workflow 134.805 in 76X which seems to indicate that GT still contains the old V4 L1T menu.

Martin-Grunewald · 2015-10-08T06:41:47Z

@diguida @mmusich @slava77
Is this via O2O? So the GT used to take the original data is used via auto::run2_hlt (and that was using v4 L1T in the GT and an older HLT menu)? but the worflow executed today wants to run the current HLT menu (requiring the v5 L1T menu)...?

diguida · 2015-10-08T08:00:23Z

@Martin-Grunewald that's correct. The HLT GT gets the L1T menu from O2O directly triggered online.
This means that the new L1T menu has not been deployed for the runs you are using for tests...

diguida · 2015-10-08T08:01:51Z

@Martin-Grunewald can you try by customising the HLT menu in autoCondHLT and check if this works?

Martin-Grunewald · 2015-10-08T08:05:29Z

@hengne
Yes, we do that already with the GT then named 'run2_hlt_25ns14e33_v3' or ''run2_hlt_25ns14e33_v4'
to indicate which HLT menu to be used, but that would have to be propagated to the workflow
test, or alternatively the specific workflow tests (but not all!) updated to use a specific frozen HLT menu compatible with the L1T menu used at the time of data taking.

diguida · 2015-10-08T08:08:36Z

ah I see. So, the driver commands should be customised in order to pick the HLT keys!

diguida · 2015-10-08T08:14:06Z

@mulhearn @kkotov this is something you might want to watch as well.

hengne · 2015-10-08T08:25:16Z

@mmusich @diguida @Martin-Grunewald you can just cherry-pick this commit here to fix the addOn test failure:
hengne@50f18c2

Martin-Grunewald · 2015-10-08T08:29:03Z

No! (I should not have signed #11424 - just added -1!)
That is a different test and the solution does not scale!
The addOn tests always need to run the most recent combination of menus - they are set up this way.

hengne · 2015-10-08T08:30:12Z

@mmusich @diguida @Martin-Grunewald OK, sorry, this doesn't apply here...

diguida · 2015-10-08T08:30:54Z

@hengne what you propose is to roll back the L1T menu... here we'd like to push forward. @Martin-Grunewald am I right?

hengne · 2015-10-08T08:31:51Z

@diguida sorry, forget what I proposed.. i am wrong here.

Martin-Grunewald · 2015-10-08T08:33:43Z

Well, what is the test supposed to test? That we can run new L1T and new HLT on old data?
Or that we can run with the new CMSSW code the old menus on old data? Probably the former...

New GTs for 76X: L1,HLT,Geometry and HCAL changes

7bf19ab

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 1, 2015

cmsbuild added alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 1, 2015

diguida mentioned this pull request Oct 1, 2015

New GT for 2017 scenario. #11600

Closed

Updating the frozen 25ns HLT menu to be consistent with change in L1 …

1904d66

…menu in GT

cmsbuild added the hlt-pending label Oct 1, 2015

diguida mentioned this pull request Oct 1, 2015

merge SLHC updates for CaloTowers #11497

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 1, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 1, 2015

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Oct 6, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2015

Martin-Grunewald mentioned this pull request Oct 6, 2015

Replace TFormula in SimpleJetCorrector #11584

Merged

davidlange6 added a commit that referenced this pull request Oct 6, 2015

Merge pull request #11609 from mmusich/GTs_for_76_v1

8f8882b

New GTs for 76X: L1,HLT,Geometry and HCAL changes

davidlange6 merged commit 8f8882b into cms-sw:CMSSW_7_6_X Oct 6, 2015

Martin-Grunewald mentioned this pull request Oct 6, 2015

76X hlt25ns round six #11548

Merged

diguida mentioned this pull request Oct 9, 2015

Fix precedence error and added additional functions #11684

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New GTs for 76X: L1,HLT,Geometry and HCAL changes #11609

New GTs for 76X: L1,HLT,Geometry and HCAL changes #11609

mmusich commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

mmusich commented Oct 1, 2015

mmusich commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

mmusich commented Oct 1, 2015

diguida commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

diguida commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

Martin-Grunewald commented Oct 6, 2015

diguida commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

Martin-Grunewald commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

diguida commented Oct 8, 2015

diguida commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

diguida commented Oct 8, 2015

diguida commented Oct 8, 2015

hengne commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

hengne commented Oct 8, 2015

diguida commented Oct 8, 2015

hengne commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

New GTs for 76X: L1,HLT,Geometry and HCAL changes #11609

New GTs for 76X: L1,HLT,Geometry and HCAL changes #11609

Conversation

mmusich commented Oct 1, 2015

Summary of changes

Run I Simulation:

Run II Simulation:

Run2 data

Run1 Data

Upgrades

cmsbuild commented Oct 1, 2015

mmusich commented Oct 1, 2015

mmusich commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

mmusich commented Oct 1, 2015

diguida commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

diguida commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

Martin-Grunewald commented Oct 6, 2015

diguida commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

Martin-Grunewald commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

diguida commented Oct 8, 2015

diguida commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

diguida commented Oct 8, 2015

diguida commented Oct 8, 2015

hengne commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015

hengne commented Oct 8, 2015

diguida commented Oct 8, 2015

hengne commented Oct 8, 2015

Martin-Grunewald commented Oct 8, 2015