Removed use of '#define private public' for testing #11610
Conversation
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Removed use of '#define private public' for testing It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
-1 >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/test/indexIntoFile_t.cppunit.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/test/indexIntoFile1_t.cppunit.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/test/indexIntoFile2_t.cppunit.cc
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/test/indexIntoFile_t.cppunit.cc:12:0:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/interface/IndexIntoFile.h: In member function 'void TestIndexIntoFile::check(const edm::IndexIntoFile::IndexIntoFileItr&, edm::IndexIntoFile::EntryType, int, int, int, long long int, long long int)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/interface/IndexIntoFile.h:780:19: error: 'edm::IndexIntoFile::EntryType edm::IndexIntoFile::IndexIntoFileItr::type() const' is private
EntryType type() const { return impl_->type(); }
^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-30-2300/src/DataFormats/Provenance/test/indexIntoFile_t.cppunit.cc:120:30: error: within this context
iter.type() == type &&
^
you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Tests had converted all private to public in order to test internals. This no longer works with newer versions of gcc since it messes up linking. Switched to using friend instead.
Dr15Jones
force-pushed
the
removePrivateToPublic
branch
from
0ef30e6 to
ed2e9d1
Compare
cmsbuild
added
core-pending
pending-signatures
and removed
core-approved
fully-signed
tests-rejected
labels
|
Pull request #11610 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: ed2e9d1 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: ed2e9d1 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
Not sure why test is failing, because first thing https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/RecoMET/METProducers/test/runtests.sh |
|
how do we clean up files after a command finishes? It seems the file is found by one subsequent job but not the next
|
|
Tried it locally and got different experience. One thing, PR tests does show cmsDriver being executed. Test: Locally: Which failed for me: I don't see cmsDriver being invoked in IBs logs also: Ah, it's a patch IB so it doesn't show the actual issues. It's failing in the normal IB also (you just need to find a full IB to see the logs with errors): https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_7_6_X_2015-10-01-1100/unitTestLogs/RecoMET/METProducers |
|
Recompiled again and testRecoMETMETProducers worked fine locally. |
|
@davidlt - i'll merge and we can see what happens... |
Removed use of '#define private public' for testing
Tests had converted all private to public in order to test internals. This no longer works with newer versions of gcc since it messes up linking. Switched to using friend instead.