Run2-hcx36 Add in the digitization code for HGCal

[bsunanda]

This is done by adding a new package SimCalorimetry/HGCalSimProducers
@lgray

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

Run2-hcx36 Add in the digitization code for HGCal

It involves the following packages:

SimCalorimetry/HGCalSimProducers

The following packages do not have a category, yet:

SimCalorimetry/HGCalSimProducers

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[bsunanda]

@lgray We want SimCalorimetry/HGCalSimProducers under Simulation category

---

From: cmsbuild [[email protected]]
Sent: 04 October 2015 15:26
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Run2-hcx36 Add in the digitization code for HGCal (#11626)

A new Pull Request was created by @bsunandahttps://github.com/bsunanda for CMSSW_7_6_X.

Run2-hcx36 Add in the digitization code for HGCal

It involves the following packages:

SimCalorimetry/HGCalSimProducers

The following packages do not have a category, yet:

SimCalorimetry/HGCalSimProducers

@cmsbuildhttps://github.com/cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@deganohttps://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11626#issuecomment-145349900.

[lgray]

@bsunanda I don't manage that.

@smuzaffar could you point us in the right direction?

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[lgray]

@bsunanda I'll rebase all the fast-tining development ontop of your branch and send you a PR. It would be best to include all the dev up to now.

[lgray]

@bsunanda actually since that involves the RecHits as well I will make a separate PR with that one after this PR is merged.

[cmsbuild]

+1
Tested at: 43f2ae7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11626/8602/summary.html

[lgray]

@smuzaffar once this one is merged can you add it to the list of SIM packages and also add @vandreev11, @pfs, and @lgray as additional watchers for the package? Thanks!

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11626/8602/summary.html

[slava77]

@lgray or @bsunanda
I suggest you edit the categories.py file and submit a PR to cms-bot
https://github.com/cms-sw/cms-bot/blob/master/categories.py

[lgray]

@slava77 @bsunanda Will do! Thanks for the pointer.

[smuzaffar]

@lgray , please also update the cms-bot/watchers.yaml file to include @vandreev11, @pfs, and @lgray as watcher for this new package.

[lgray]

@smuzaffar cms-sw/cms-bot#542 for this package and watchers.

[smuzaffar]

cms-bot changes merged. This PR now needs simulation signatures

[lgray]

@civanch @mdhildreth

[lgray]

@civanch @mdhildreth (sorry for spam) This now needs your signature, we have just added it as a watched simulations package. Please review this PR! Thanks!

[lgray]

@civanch @mdhildreth Please review this PR. Thank you!

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1