Fireworks cleanup for {private,protected} macro removal #11641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2015 21:59
`FWEventItem::getPrimaryData` is being used by `FWFileEntry` (Fireworks code), but uses `#define private public` to get access to it. The patch makes it public that private re-define could be removed. Signed-off-by: David Abdurachmanov <[email protected]>
Fireworks code relies a lot on re-defining {private,protected} to get
access to various ROOT classes internals. Those re-defines are also
breaking GNU C++ Standard Library (libstdc++v3). Some are already
available via ROOT public APIs and the patch updates Fireworks code to
utilise them.
Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. Fireworks cleanup for {private,protected} macro removal It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. |
davidlange6
added a commit
that referenced
this pull request
Oct 8, 2015
Fireworks cleanup for {private,protected} macro removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits in this PR makes sure that Fireworks code uses already available public APIs either from ROOT or from Fireworks code itself. This builds fine, but requires testing various affected places to make sure that behaviour is not changed.
Proportional work for cleanup of {private,protect} macros.