Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hcal digitization changes the default #11675

Merged
merged 1 commit into from
Oct 8, 2015

Conversation

davidlange6
Copy link
Contributor

time slew parameters and hf1 sampling factors now the default - consistent with GT in 76x already

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_6_X.

make hcal digitization changes the default

It involves the following packages:

RecoLocalCalo/HcalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HcalSimProducers

@cmsbuild, @cvuosalo, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

-1

Tested at: e7b3117
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 22:23:15 2015-date Wed Oct 7 22:18:53 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 22:31:51 2015-date Wed Oct 7 22:28:54 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 7 22:39:05 2015-date Wed Oct 7 22:34:10 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11675/8676/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

@davidlange6
Copy link
Contributor Author

@slava77 - the customizeHLTforMC function is not touched in this PR - I think it can be removed though.

davidlange6 added a commit that referenced this pull request Oct 8, 2015
make hcal digitization changes the default
@davidlange6 davidlange6 merged commit 46d925a into cms-sw:CMSSW_7_6_X Oct 8, 2015
@slava77
Copy link
Contributor

slava77 commented Oct 8, 2015

On 10/8/15 1:00 AM, David Lange wrote:

@slava77 https://github.com/slava77 - the customizeHLTforMC function
is not touched in this PR - I think it can be removed though.

OK.
But this also means that this PR modifies only DIGI step in a noticeable
way.


Reply to this email directly or view it on GitHub
#11675 (comment).

@davidlange6
Copy link
Contributor Author

On Oct 8, 2015, at 8:09 AM, Slava Krutelyov [email protected] wrote:

On 10/8/15 1:00 AM, David Lange wrote:

@slava77 https://github.com/slava77 - the customizeHLTforMC function
is not touched in this PR - I think it can be removed though.

OK.
But this also means that this PR modifies only DIGI step in a noticeable
way.

ah - sorry - indeed, I need to update that. Thanks!


Reply to this email directly or view it on GitHub
#11675 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants