Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GT with PF hadron calibration. #11697

Merged
merged 1 commit into from
Oct 8, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Oct 8, 2015

PF hadron calibration computed on top of the changes in HCAL digitisation and time slew model is added to all scenarios.

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2015

please test
should work out-of-the-box

@diguida
Copy link
Contributor Author

diguida commented Oct 8, 2015

@slava77 this is the "minimal" set of GT with only the new PF Calibration.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8702/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X.

New GT with PF hadron calibration.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

-1

Tested at: 0f6a2c6
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 20:12:07 2015-date Thu Oct 8 20:06:14 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 20:21:57 2015-date Thu Oct 8 20:18:42 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 20:28:50 2015-date Thu Oct 8 20:24:07 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11697/8702/summary.html

@davidlange6
Copy link
Contributor

merging - please comment on any issues in parallel with the IB!. Thanks

davidlange6 added a commit that referenced this pull request Oct 8, 2015
@davidlange6 davidlange6 merged commit e0e35dc into cms-sw:CMSSW_7_6_X Oct 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

@slava77
Copy link
Contributor

slava77 commented Oct 8, 2015

The subject of the PR may be a bit misleading.
"PF hadron calibration computed on top of the changes in HCAL method3 with time slew model"

  • method 3 is not used to reconstruct energies in reco. So, it's just the slewing and other digitization changes.

@diguida
Copy link
Contributor Author

diguida commented Oct 9, 2015

@slava77 thanks for your comment: I wrote it in a rush.
I have just changed it to: PF hadron calibration computed on top of the changes in HCAL digitisation and time slew model is added to all scenarios.

Is it ok?

@diguida
Copy link
Contributor Author

diguida commented Oct 9, 2015

@diguida
Copy link
Contributor Author

diguida commented Oct 9, 2015

@ggovi one of the unit test failures in the latest IB is related to the missing key for accessing ORACLE in read-only mode: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc493/CMSSW_7_6_X_2015-10-08-2300/unitTestLogs/CondCore/DBCommon

@mmusich
Copy link
Contributor

mmusich commented Oct 9, 2015

please test

@diguida
Copy link
Contributor Author

diguida commented Oct 9, 2015

To clarify more. The test errors in this PR are due to the fact that the IB used as baseline for tests here https://cmssdt.cern.ch/SDT/html/showIB.html#CMSSW_7_6_X_2015-10-07-2300 does not contain the TMath fix in #11684: this latter PR entered https://cmssdt.cern.ch/SDT/html/showIB.html#CMSSW_7_6_X_2015-10-08-1100

@ggovi
Copy link
Contributor

ggovi commented Oct 9, 2015

@diguida
Probably related to expired afs token... Any action required on this?

@slava77
Copy link
Contributor

slava77 commented Oct 9, 2015

On 10/9/15 3:19 AM, Salvatore Di Guida wrote:

@slava77 https://github.com/slava77 thanks for your comment: I wrote
it in a rush.
I have just changed it to: PF hadron calibration computed on top of the
changes in HCAL digitisation and time slew model is added to all scenarios.

Is it ok?

Thank you. It looks more clear now.


Reply to this email directly or view it on GitHub
#11697 (comment).

@diguida
Copy link
Contributor Author

diguida commented Oct 9, 2015

@ggovi I could not reproduce it, so I think it is an issue with afs...
Thanks for your check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants