Fix the duplicated HF channels

[lihux25]

Throw a LogError if this is found and an empty HF digi collection is put into event.

See discussion thread https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1390.html for more information.

[cmsbuild]

A new Pull Request was created by @lihux25 (Hongxuan Liu) for CMSSW_7_4_X.

Fix the duplicated HF channels

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[slava77]

@lihux25
please make 75X and 76X PRs with the same change

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8709/console

[cmsbuild]

+1
Tested at: 18c6691
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11702/8709/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11702/8709/summary.html

[slava77]

+1

for #11702 18c6691

• changes in the code are in line with the intended fix for the crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1390.html
• jenkins tests pass and comparisons with baseline show no differences (as expected on good data inputs)
• tested locally in CMSSW_7_4_14
  • with several run2 PromptReco workflows (2 in 2015B, 1 in 2015C and 2 in 2015D, 200 events each) observe no differences as expected
  • the crash is now gone: the same (previously crashing) input file processing has quite a few more events with bad HF data: they all appear with the error message now, e.g. (some have more than 20 times)

%MSG-e HcalRawToDigi:  HcalRawToDigi:hcalDigis 09-Oct-2015 18:45:28 CEST  Run: 258177 Event: 2673815518
Duplicated HF digis found for 20 times

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1