-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cryptic assert with informative exception for missing Wrapper dictionary #11703
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Replace cryptic assert with informative exception for missing Wrapper dictionary It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Replace cryptic assert with informative exception for missing Wrapper dictionary
If an attempt is made to produce a product whose wrapped class (edm::Wrapper) does not have a dictionary, a cryptic assert resulted. This cryptic assert could also occur for other reasons.
This simple PR replaces the cryptic assert with an informative exception, which in the above case is a missing dictionary exception. This PR also fixes another minor problem. If TypeWithDict::name() or any related function was used to get the name of a class that has no dictionary, "dummyType" was returned, rather than the correct name of the class.
This problem is ROOT6 specific, but it also occurs in CMSSW_7_5_X. This fix can be back ported to 7_5_X if needed. This problem does not directly affect 7_4_X.