Updating to latest fastjet contrib Nsubjettiness #11791

rappoccio · 2015-10-14T14:22:18Z

This requires the new fastjet-contrib 1.020:

cmsbuild · 2015-10-14T14:26:11Z

A new Pull Request was created by @rappoccio for CMSSW_7_6_X.

Updating to latest fastjet contrib Nsubjettiness

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-10-14T14:57:58Z

I suppose a simple "please test" will not work with jenkins.
@smuzaffar @Degano : is it possible to request a joint build via jenkins (of this PR and a cms-dist change .. if it were to exist)?

cvuosalo · 2015-10-23T18:45:43Z

@smuzaffar, @Degano: Could you please help with testing this PR? It needs to be combined with cms-sw/cmsdist#1891

smuzaffar · 2015-10-24T09:33:52Z

@Degano is working on a jenkins job to start jenkins tests for PRs which need external changes. Script is not yet ready , hopefully next week we will have something working which would allow L2's to say "[@cmsbuild, ]please test[ with cms-sw/cmsdist#PR]"

cvuosalo · 2015-10-28T18:41:10Z

@Degano: Will the special Jenkins testing be ready this week?

slava77 · 2015-11-02T15:20:48Z

I'm curious if the functionality is available already.
Slides in the last Core meeting were suggestive that it's essentially there.
Is it?

slava77 · 2015-11-04T13:51:16Z

@smuzaffar @Degano
please comment if the joint cmssw and cmsdist test is possible now
( "[@cmsbuild, ]please test[ with cms-sw/cmsdist#PR]" or similar)

slava77 · 2015-11-09T23:28:01Z

@smuzaffar @Degano
please comment if the joint cmssw and cmsdist test is possible now
( "[@cmsbuild, ]please test[ with cms-sw/cmsdist#PR]" or similar)

cvuosalo · 2015-11-10T22:36:15Z

@cmsbuild please test with cms-sw/cmsdist#1891

cmsbuild · 2015-11-10T23:08:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/test-cmsdist-cmssw-test-pr/23/console

slava77 · 2015-11-11T19:02:20Z

@cmsbuild please test with cms-sw/cmsdist#1891
[it's been 20 hours without any progress]

@smuzaffar @Degano
I can't find this PR tests in jenkins integration tests

When trying to rebuild via https://cmssdt.cern.ch/jenkins/job/ib-schedule-pr-tests/build?delay=0sec
I don't see the option there to put a CMSDIST. So, a manual resubmission from the this probably wouldn't work.

smuzaffar · 2015-11-11T20:38:14Z

I am looking in to it.

smuzaffar · 2015-11-11T20:41:17Z

The jenkins job for this is
https://cmssdt.cern.ch/jenkins/job/test-cmsdist-cmssw-test-pr/22/console

and looks like it does not work if PR is merged and user branch is deleted.

slava77 · 2015-11-11T21:58:28Z

@cmsbuild please test with cms-sw/cmsdist#1953

let's see if this makes more sense

cmsbuild · 2015-11-12T01:12:36Z

-1
Tested at: 22eecfd
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/PileupJetIdProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/PtMinJetSelector.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/QGTagger.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/QjetsAdder.cc 
/build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/NjettinessAdder.cc: In constructor 'NjettinessAdder::NjettinessAdder(const edm::ParameterSet&)':
/build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/NjettinessAdder.cc:30:3: error: 'OriginalGeometricMeasure' is not a member of 'fastjet::contrib'
   fastjet::contrib::OriginalGeometricMeasure   geometricMeasure         (beta_);// changed in 1.020
   ^
/build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_6_X_2015-11-11-1100/src/RecoJets/JetProducers/plugins/NjettinessAdder.cc:38:52: error: 'geometricMeasure' was not declared in this scope
   case OriginalGeometricMeasure    : measureDef = &geometricMeasure; break;// changed in 1.020
                                                    ^

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11791/23/summary.html

smuzaffar · 2015-12-10T10:15:23Z

please test with cms-sw/cmsdist#4723948
(wrong PR number given to test cms-bot functionality)

cmsbuild · 2015-12-10T10:15:44Z

Ignoring test request.
ERROR: Unable to find cmsdist Pull request cms-sw/cmsdist#4723948

smuzaffar · 2015-12-10T10:17:33Z

please test with cms-sw/cmsdist#2029

cmsbuild · 2015-12-10T15:26:26Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2029
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/16/console

Updating to latest fastjet contrib Nsubjettiness

cmsbuild · 2015-12-10T17:41:33Z

-1
Tested at: 31a54c1
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11791/13/summary.html

cmsbuild · 2015-12-10T19:51:33Z

+1
Tested at: 31a54c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11791/16/summary.html

cmsbuild · 2015-12-10T20:46:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11791/16/summary.html

Updating to latest fastjet contrib Nsubjettiness

22eecfd

rappoccio mentioned this pull request Oct 14, 2015

Advance fastjet-contrib to version cms/v1.020. cms-sw/cmsdist#1891

Merged

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 14, 2015

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 14, 2015

cmsbuild mentioned this pull request Oct 19, 2015

Updating to latest fastjet contrib Nsubjettiness #11911

Merged

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2015

This was referenced Nov 11, 2015

fastjet 1.020 specs from https://github.com/cms-sw/cmsdist/pull/1891 slava77/cmsdist#1

Closed

fastjet 1.020 specs from https://github.com/cms-sw/cmsdist/pull/1891 cms-sw/cmsdist#1953

Closed

cmsbuild added tests-rejected and removed tests-started labels Nov 12, 2015

cmsbuild added comparison-available tests-approved and removed tests-rejected labels Dec 10, 2015

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Dec 10, 2015

cmsbuild mentioned this pull request Dec 10, 2015

updated fastjet-contrib to use the latest 1.020 fixes cms-sw/cmsdist#2029

Merged

cmsbuild added tests-started tests-pending and removed tests-pending tests-started labels Dec 10, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 10, 2015

smuzaffar added a commit that referenced this pull request Dec 10, 2015

Merge pull request #11791 from rappoccio/rappoccio_fjcontrib_1.020_76x

e617134

Updating to latest fastjet contrib Nsubjettiness

smuzaffar merged commit e617134 into cms-sw:CMSSW_7_6_X Dec 10, 2015

cmsbuild added tests-rejected and removed tests-started labels Dec 10, 2015

cmsbuild added tests-approved and removed tests-rejected labels Dec 10, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 10, 2015

rappoccio deleted the rappoccio_fjcontrib_1.020_76x branch February 3, 2018 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating to latest fastjet contrib Nsubjettiness #11791

Updating to latest fastjet contrib Nsubjettiness #11791

rappoccio commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

slava77 commented Oct 14, 2015

cvuosalo commented Oct 23, 2015

smuzaffar commented Oct 24, 2015

cvuosalo commented Oct 28, 2015

slava77 commented Nov 2, 2015

slava77 commented Nov 4, 2015

slava77 commented Nov 9, 2015

cvuosalo commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

slava77 commented Nov 11, 2015

smuzaffar commented Nov 11, 2015

smuzaffar commented Nov 11, 2015

slava77 commented Nov 11, 2015

cmsbuild commented Nov 12, 2015

smuzaffar commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

smuzaffar commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

Updating to latest fastjet contrib Nsubjettiness #11791

Updating to latest fastjet contrib Nsubjettiness #11791

Conversation

rappoccio commented Oct 14, 2015

cmsbuild commented Oct 14, 2015

slava77 commented Oct 14, 2015

cvuosalo commented Oct 23, 2015

smuzaffar commented Oct 24, 2015

cvuosalo commented Oct 28, 2015

slava77 commented Nov 2, 2015

slava77 commented Nov 4, 2015

slava77 commented Nov 9, 2015

cvuosalo commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

slava77 commented Nov 11, 2015

smuzaffar commented Nov 11, 2015

smuzaffar commented Nov 11, 2015

slava77 commented Nov 11, 2015

cmsbuild commented Nov 12, 2015

smuzaffar commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

smuzaffar commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015

cmsbuild commented Dec 10, 2015