Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CondFormats/Common: remove intrusive macros breaking libstdc++ #11950

Closed
wants to merge 1 commit into from
Closed

CondFormats/Common: remove intrusive macros breaking libstdc++ #11950

wants to merge 1 commit into from

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 19, 2015

We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov [email protected]

CondFormats/Common: remove intrusive macros breaking libstdc++
5627df6 
We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.

This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.

Details in PR65899 (GCC BZ). It's WONTFIX.

Such cleanups are required for GCC 5 and above.

Signed-off-by: David Abdurachmanov <[email protected]>
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 19, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

CondFormats/Common: remove intrusive macros breaking libstdc++

It involves the following packages:

CondFormats/Common

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Oct 19, 2015

Missed a few, will update.

@davidlt davidlt closed this Oct 19, 2015
@davidlt
Copy link
Contributor Author

davidlt commented Oct 19, 2015

I was wrong, this is good enough.

@davidlt davidlt reopened this Oct 19, 2015
@davidlt
Copy link
Contributor Author

davidlt commented Oct 19, 2015

Launched the tests.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5627df6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11950/9001/summary.html

@davidlt davidlt mentioned this pull request Oct 19, 2015
Closed
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11950/9001/summary.html

@davidlt
Copy link
Contributor Author

davidlt commented Oct 26, 2015

Closed for CMSSW_7_6_X, look at PR for CMSSW_8_0_X.

@davidlt davidlt closed this Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available db-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlt @cmsbuild