Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding H->inv paths to the HLT Higgs dqm #12014

Closed
wants to merge 2 commits into from
Closed

Adding H->inv paths to the HLT Higgs dqm #12014

wants to merge 2 commits into from

Conversation

jasperlauwers
Copy link
Contributor

Backport of #11636

Adding paths to the dqm:
"HLT_DiPFJet40_DEta3p5_MJJ600_PFMETNoMu140_v",
"HLT_DiPFJet40_DEta3p5_MJJ600_PFMETNoMu80_v",
"HLT_DiPFJet40_DEta3p5_MJJ600_PFMETNoMu140_JetIdCleaned_v",
"HLT_DiPFJet40_DEta3p5_MJJ600_PFMETNoMu80_JetIdCleaned_v"

The naming of these paths required an additional fix in the code as well.

@jasperlauwers
Adding vbf H to Invisible paths + associated code fix
1d3dd0f 
Conflicts:
	HLTriggerOffline/Higgs/python/hltHiggsPostProcessors_cff.py
	HLTriggerOffline/Higgs/python/hltHiggsValidator_cfi.py
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Oct 21, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jasperlauwers for CMSSW_7_4_X.

Adding H->inv paths to the HLT Higgs dqm

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6 davidlange6 modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@cmsbuild cmsbuild modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

this one should be submitted to 75x, 76x, 80x as well for consistency

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9280/console

@cmsbuild
Copy link
Contributor

Pull request #12014 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@jasperlauwers
Copy link
Contributor Author

It is already in 76x, as it is a backport of #11636
And my PR in 75x was getting closed before because of "not needed for HeavyIons (only planned 75x usage)" ( #11342 )

The last commit adds a fix as was seen to be necessary in 76X ( issue #12036, fix #12048 ).

@cmsbuild
Copy link
Contributor

+1
Tested at: 39e4e16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12014/9280/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12014/9280/summary.html

@deguio
Copy link
Contributor

deguio commented Oct 29, 2015

+1
thanks for clarifying

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@jasperlauwers @cmsbuild @deguio @davidlange6