Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Change: reading tags from CondDBv2 #12228

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 2, 2015

Backported from 80X (#12094)

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2015

@diguida @franzoni

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_6_X.

Minimal Change: reading tags from CondDBv2

It involves the following packages:

RecoTauTag/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9414/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 2, 2015

+1

For #12228 5f89c7b

Small change for reading tau tags from CondDBv2. #12094 is the 80X version of this PR, and it has already been merged.

Jenkins tests against baseline CMSSW_7_6_X_2015-11-01-2300 show no significant differences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 2, 2015
Minimal Change: reading tags from CondDBv2
@cmsbuild cmsbuild merged commit 04c47fc into cms-sw:CMSSW_7_6_X Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants